Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5267

Add a configuration to disable the slab cache by default

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 0.92.1, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      From what I commented at the tail of HBASE-4027:

      I changed the release note, the patch doesn't have a "hbase.offheapcachesize" configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize (which is actually a big problem when you consider this: http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).

      We need to add hbase.offheapcachesize and set it to false by default.

      Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.

      1. 5267.txt
        1 kB
        Li Pi
      2. 5267v2.txt
        2 kB
        Li Pi
      3. 5267v3.txt
        2 kB
        Ted Yu
      4. 5267v4.txt
        3 kB
        Ted Yu

        Activity

        Hide
        li@idle.li Li Pi added a comment -

        Will take care of this asap.

        On Mon, Jan 23, 2012 at 4:57 PM, Jean-Daniel Cryans (Created) (JIRA)

        Show
        li@idle.li Li Pi added a comment - Will take care of this asap. On Mon, Jan 23, 2012 at 4:57 PM, Jean-Daniel Cryans (Created) (JIRA)
        Hide
        li Li Pi added a comment -

        Fixed. Block cache now defaults to disabled.

        Show
        li Li Pi added a comment - Fixed. Block cache now defaults to disabled.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12511652/5267.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -145 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 84 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestMasterObserver

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/846//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/846//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/846//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511652/5267.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -145 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 84 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/846//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/846//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/846//console This message is automatically generated.
        Hide
        stack stack added a comment -

        lgtm

        Show
        stack stack added a comment - lgtm
        Hide
        jdcryans Jean-Daniel Cryans added a comment -

        I'd like to see this configuration added to hbase-default.xml with some documentation, also it should be documented in the book. hbase-env.sh also needs some fixin:

        # Set hbase.offheapcachesize in hbase-site.xml

        Show
        jdcryans Jean-Daniel Cryans added a comment - I'd like to see this configuration added to hbase-default.xml with some documentation, also it should be documented in the book. hbase-env.sh also needs some fixin: # Set hbase.offheapcachesize in hbase-site.xml
        Hide
        li Li Pi added a comment -

        Did all of the above except for adding it to the book.

        Show
        li Li Pi added a comment - Did all of the above except for adding it to the book.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12512907/5267v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/893//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512907/5267v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/893//console This message is automatically generated.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Same as patch v2.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Same as patch v2.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513393/5267v3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestAdmin
        org.apache.hadoop.hbase.mapreduce.TestImportTsv
        org.apache.hadoop.hbase.mapred.TestTableMapReduce
        org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/905//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/905//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/905//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513393/5267v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/905//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/905//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/905//console This message is automatically generated.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        @J-D:
        Do you want to take a look at patch v3 ?

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - @J-D: Do you want to take a look at patch v3 ?
        Hide
        jdcryans Jean-Daniel Cryans added a comment -

        I'm +1 with the patch, but eventually I'd still like to see something in the book about it.

        Show
        jdcryans Jean-Daniel Cryans added a comment - I'm +1 with the patch, but eventually I'd still like to see something in the book about it.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        I was about to create a sub-task but found that '3.2.10. Experimental off-heap cache' points to:
        http://www.cloudera.com/blog/2012/01/caching-in-hbase-slabcache/

        Would an update of that blog suffice ?

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - I was about to create a sub-task but found that '3.2.10. Experimental off-heap cache' points to: http://www.cloudera.com/blog/2012/01/caching-in-hbase-slabcache/ Would an update of that blog suffice ?
        Hide
        jdcryans Jean-Daniel Cryans added a comment -

        Pointing to it might be a good option, along with a line or two on how to use it.

        Show
        jdcryans Jean-Daniel Cryans added a comment - Pointing to it might be a good option, along with a line or two on how to use it.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Patch v4 adds the new config parameter to src/docbkx/upgrading.xml

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Patch v4 adds the new config parameter to src/docbkx/upgrading.xml
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513543/5267v4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -136 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/909//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/909//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/909//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513543/5267v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -136 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/909//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/909//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/909//console This message is automatically generated.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Integrated to 0.92 and TRUNK.

        Thanks for the patch, Li.

        Thanks for the review, J-D.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Integrated to 0.92 and TRUNK. Thanks for the patch, Li. Thanks for the review, J-D.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92 #272 (See https://builds.apache.org/job/HBase-0.92/272/)
        HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)

        tedyu :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/conf/hbase-env.sh
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • /hbase/branches/0.92/src/main/resources/hbase-default.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92 #272 (See https://builds.apache.org/job/HBase-0.92/272/ ) HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi) tedyu : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/conf/hbase-env.sh /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java /hbase/branches/0.92/src/main/resources/hbase-default.xml
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK-security #101 (See https://builds.apache.org/job/HBase-TRUNK-security/101/)
        HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)

        tedyu :
        Files :

        • /hbase/trunk/conf/hbase-env.sh
        • /hbase/trunk/src/docbkx/upgrading.xml
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • /hbase/trunk/src/main/resources/hbase-default.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK-security #101 (See https://builds.apache.org/job/HBase-TRUNK-security/101/ ) HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi) tedyu : Files : /hbase/trunk/conf/hbase-env.sh /hbase/trunk/src/docbkx/upgrading.xml /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java /hbase/trunk/src/main/resources/hbase-default.xml
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/)
        HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)

        tedyu :
        Files :

        • /hbase/trunk/conf/hbase-env.sh
        • /hbase/trunk/src/docbkx/upgrading.xml
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • /hbase/trunk/src/main/resources/hbase-default.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/ ) HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi) tedyu : Files : /hbase/trunk/conf/hbase-env.sh /hbase/trunk/src/docbkx/upgrading.xml /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java /hbase/trunk/src/main/resources/hbase-default.xml
        Hide
        jdcryans Jean-Daniel Cryans added a comment -

        This has been solved.

        Show
        jdcryans Jean-Daniel Cryans added a comment - This has been solved.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/)
        HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi) (Revision 1241643)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/conf/hbase-env.sh
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • /hbase/branches/0.92/src/main/resources/hbase-default.xml
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92-security #91 (See https://builds.apache.org/job/HBase-0.92-security/91/ ) HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi) (Revision 1241643) Result = FAILURE tedyu : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/conf/hbase-env.sh /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java /hbase/branches/0.92/src/main/resources/hbase-default.xml

          People

          • Assignee:
            li Li Pi
            Reporter:
            jdcryans Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development