HBase
  1. HBase
  2. HBASE-5179

Concurrent processing of processFaileOver and ServerShutdownHandler may cause region to be assigned before log splitting is completed, causing data loss

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.90.2
    • Fix Version/s: 0.92.3
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If master's processing its failover and ServerShutdownHandler's processing happen concurrently, it may appear following case.
      1.master completed splitLogAfterStartup()
      2.RegionserverA restarts, and ServerShutdownHandler is processing.
      3.master starts to rebuildUserRegions, and RegionserverA is considered as dead server.
      4.master starts to assign regions of RegionserverA because it is a dead server by step3.

      However, when doing step4(assigning region), ServerShutdownHandler may be doing split log, Therefore, it may cause data loss.

      1. hbase-5179v9.patch
        14 kB
        chunhui shen
      2. hbase-5179v8.patch
        12 kB
        chunhui shen
      3. hbase-5179v7.patch
        10 kB
        chunhui shen
      4. hbase-5179v6.patch
        9 kB
        chunhui shen
      5. hbase-5179v5.patch
        8 kB
        chunhui shen
      6. hbase-5179v17.patch
        21 kB
        Ted Yu
      7. hbase-5179v12.patch
        20 kB
        chunhui shen
      8. hbase-5179v10.patch
        19 kB
        chunhui shen
      9. hbase-5179.patch
        7 kB
        chunhui shen
      10. Errorlog
        28 kB
        gaojinchao
      11. 5179-v4.txt
        7 kB
        Ted Yu
      12. 5179-v3.txt
        7 kB
        Ted Yu
      13. 5179-v2.txt
        7 kB
        Ted Yu
      14. 5179-v11-92.txt
        17 kB
        Ted Yu
      15. 5179-v11.txt
        18 kB
        Ted Yu
      16. 5179-92v17.patch
        20 kB
        Ted Yu
      17. 5179-90v9.patch
        20 kB
        chunhui shen
      18. 5179-90v8.patch
        19 kB
        chunhui shen
      19. 5179-90v7.patch
        17 kB
        chunhui shen
      20. 5179-90v6.patch
        17 kB
        chunhui shen
      21. 5179-90v5.patch
        14 kB
        chunhui shen
      22. 5179-90v4.patch
        9 kB
        gaojinchao
      23. 5179-90v3.patch
        14 kB
        gaojinchao
      24. 5179-90v2.patch
        9 kB
        chunhui shen
      25. 5179-90v18.txt
        24 kB
        Ted Yu
      26. 5179-90v17.txt
        24 kB
        Ted Yu
      27. 5179-90v16.patch
        24 kB
        chunhui shen
      28. 5179-90v15.patch
        24 kB
        chunhui shen
      29. 5179-90v14.patch
        22 kB
        chunhui shen
      30. 5179-90v13.txt
        22 kB
        Ted Yu
      31. 5179-90v12.patch
        22 kB
        chunhui shen
      32. 5179-90v11.patch
        19 kB
        Ted Yu
      33. 5179-90v10.patch
        20 kB
        Ted Yu
      34. 5179-90.txt
        8 kB
        Ted Yu

        Issue Links

          Activity

          chunhui shen created issue -
          chunhui shen made changes -
          Field Original Value New Value
          Affects Version/s 0.90.2 [ 12316152 ]
          chunhui shen made changes -
          Attachment hbase-5179.patch [ 12510164 ]
          chunhui shen made changes -
          Description If master's processing its failover and ServerShutdownHandler's processing happen concurrently, it may appear following case.
          1.master completing splitLogAfterStartup()
          2.RegionserverA restarts, and ServerShutdownHandler is processing.
          3.master starts to rebuildUserRegions, and RegionserverA is considered as dead server.
          4.master starts to assign regions of RegionserverA because it is a dead server by step3.

          However, when doing step4(assigning region), ServerShutdownHandler may be doing split log, Therefore, it may cause data loss.
          If master's processing its failover and ServerShutdownHandler's processing happen concurrently, it may appear following case.
          1.master completed splitLogAfterStartup()
          2.RegionserverA restarts, and ServerShutdownHandler is processing.
          3.master starts to rebuildUserRegions, and RegionserverA is considered as dead server.
          4.master starts to assign regions of RegionserverA because it is a dead server by step3.

          However, when doing step4(assigning region), ServerShutdownHandler may be doing split log, Therefore, it may cause data loss.
          Ted Yu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ted Yu made changes -
          Attachment 5179-v2.txt [ 12510206 ]
          Ted Yu made changes -
          Attachment 5179-90.txt [ 12510215 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510215/5179-90.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/732//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-90.txt [ 12510215 ]
          Ted Yu made changes -
          Attachment 5179-90.txt [ 12510261 ]
          Ted Yu made changes -
          Comment [ TestRollingRestart fails in 0.90 with patch. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510261/5179-90.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/733//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-v3.txt [ 12510266 ]
          Ted Yu made changes -
          Attachment 5179-v4.txt [ 12510277 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510164/hbase-5179.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -147 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.mapreduce.TestImportTsv
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/728//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/728//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/728//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510266/5179-v3.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -147 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 80 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestImportTsv

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/735//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/735//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/735//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v5.patch [ 12510304 ]
          chunhui shen made changes -
          Attachment 5179-90v2.patch [ 12510311 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510311/5179-90v2.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/744//console

          This message is automatically generated. ]
          gaojinchao made changes -
          Attachment 5179-90v3.patch [ 12510379 ]
          gaojinchao made changes -
          Attachment 5179-90v3.patch [ 12510379 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510379/5179-90v3.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/745//console

          This message is automatically generated. ]
          gaojinchao made changes -
          Attachment 5179-90v3.patch [ 12510381 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510381/5179-90v3.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/746//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ @Ram:
          I don't see patch attached to hbase-4748.
          Are you going to provide a combined patch ?
          ]
          Ted Yu made changes -
          Comment [ Since Ram is busy with releasing 0.90.6, I think we should check in the patch for this issue.
          Hbase-4748 can be tackled in its own Jira. ]
          Ted Yu made changes -
          Summary Concurrent processing of processFaileOver and ServerShutdownHandler may cause region is assigned before completing split log, it would cause data loss Concurrent processing of processFaileOver and ServerShutdownHandler may cause region to be assigned before log splitting is completed, causing data loss
          Hadoop Flags Reviewed [ 10343 ]
          ramkrishna.s.vasudevan made changes -
          Link This issue incorporates HBASE-4748 [ HBASE-4748 ]
          Ted Yu made changes -
          Fix Version/s 0.92.0 [ 12314223 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.90.6 [ 12319200 ]
          Priority Major [ 3 ] Critical [ 2 ]
          ramkrishna.s.vasudevan made changes -
          Comment [ sorry,the patch v3 does not work. when master is starting, shutdownhandler flow can't get the meta flag.

          I didn't find a good way to solve this problem. so I need analyze the flow deeply and need some time. ]
          ramkrishna.s.vasudevan made changes -
          Comment [ Meta Data issue is very difficult to deal. Some scenarios doesnot work.
          Please resolve this issue firstly.

          ]
          gaojinchao made changes -
          Attachment 5179-90v4.patch [ 12510577 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510577/5179-90v4.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/760//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v6.patch [ 12510660 ]
          chunhui shen made changes -
          Attachment hbase-5179v7.patch [ 12510663 ]
          chunhui shen made changes -
          Attachment 5179-90v5.patch [ 12510665 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510665/5179-90v5.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/770//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ +1 on patch v7 for TRUNK. ]
          chunhui shen made changes -
          Attachment 5179-90v6.patch [ 12510673 ]
          chunhui shen made changes -
          Attachment 5179-90v7.patch [ 12510674 ]
          ramkrishna.s.vasudevan made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510674/5179-90v7.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/773//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment 5179-90v8.patch [ 12510799 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510799/5179-90v8.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/785//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510660/hbase-5179v6.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/767//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510673/5179-90v6.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/772//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v8.patch [ 12510802 ]
          chunhui shen made changes -
          Attachment 5179-90v9.patch [ 12510811 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510811/5179-90v9.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/789//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v9.patch [ 12510813 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510802/hbase-5179v8.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -145 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 83 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.mapreduce.TestImportTsv
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/786//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/786//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/786//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v10.patch [ 12510958 ]
          Ted Yu made changes -
          Attachment 5179-v11.txt [ 12511011 ]
          Ted Yu made changes -
          Attachment 5179-v11-92.txt [ 12511020 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511020/5179-v11-92.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/807//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-90v10.patch [ 12511030 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511030/5179-90v10.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/809//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-90v11.patch [ 12511043 ]
          chunhui shen made changes -
          Attachment 5179-90v12.patch [ 12511102 ]
          chunhui shen made changes -
          Attachment hbase-5179v12.patch [ 12511103 ]
          gaojinchao made changes -
          Attachment Errorlog [ 12511134 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511134/Errorlog
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/812//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-90v13.txt [ 12511158 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511158/5179-90v13.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/813//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment 5179-90v14.patch [ 12511216 ]
          chunhui shen made changes -
          Attachment 5179-90v15.patch [ 12511218 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511218/5179-90v15.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/815//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511216/5179-90v14.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/814//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment 5179-90v16.patch [ 12511256 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511256/5179-90v16.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/816//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510206/5179-v2.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -147 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.master.TestSplitLogManager
                            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                            org.apache.hadoop.hbase.client.TestAdmin
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestImportTsv

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/730//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/730//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/730//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510277/5179-v4.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -147 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 79 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.mapreduce.TestImportTsv
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/737//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/737//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/737//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Attachment 5179-90v17.txt [ 12511281 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12510304/hbase-5179v5.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 javadoc. The javadoc tool appears to have generated -147 warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 80 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

               -1 core tests. The patch failed these unit tests:
                                 org.apache.hadoop.hbase.mapreduce.TestImportTsv
                            org.apache.hadoop.hbase.regionserver.wal.TestHLog
                            org.apache.hadoop.hbase.mapred.TestTableMapReduce
                            org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/741//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/741//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/741//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511281/5179-90v17.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/817//console

          This message is automatically generated. ]
          chunhui shen made changes -
          Attachment hbase-5179v17.patch [ 12511355 ]
          chunhui shen made changes -
          Attachment hbase-5179v17.patch [ 12511357 ]
          chunhui shen made changes -
          Attachment 5179-92v17.patch [ 12511358 ]
          Ted Yu made changes -
          Attachment hbase-5179v17.patch [ 12511357 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511358/5179-92v17.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/821//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Comment [ v17patch for 92 ]
          Ted Yu made changes -
          Attachment hbase-5179v17.patch [ 12511355 ]
          Ted Yu made changes -
          Attachment 5179-92v17.patch [ 12511358 ]
          Ted Yu made changes -
          Attachment hbase-5179v17.patch [ 12511362 ]
          Ted Yu made changes -
          Attachment 5179-92v17.patch [ 12511367 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511367/5179-92v17.patch
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/823//console

          This message is automatically generated. ]
          stack made changes -
          Fix Version/s 0.92.1 [ 12318551 ]
          Fix Version/s 0.92.0 [ 12314223 ]
          Ted Yu made changes -
          Attachment 5179-90v18.txt [ 12511589 ]
          Ted Yu made changes -
          Comment [ -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12511589/5179-90v18.txt
            against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              -1 tests included. The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.

              -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/844//console

          This message is automatically generated. ]
          Ted Yu made changes -
          Link This issue is related to HBASE-5270 [ HBASE-5270 ]
          ramkrishna.s.vasudevan made changes -
          Fix Version/s 0.90.7 [ 12319481 ]
          Fix Version/s 0.90.6 [ 12319200 ]
          Eugene Koontz made changes -
          Link This issue is related to HBASE-5202 [ HBASE-5202 ]
          stack made changes -
          Fix Version/s 0.92.2 [ 12319888 ]
          Fix Version/s 0.94.0 [ 12316419 ]
          Fix Version/s 0.92.1 [ 12318551 ]
          Fix Version/s 0.90.7 [ 12319481 ]
          stack made changes -
          Fix Version/s 0.92.3 [ 12321692 ]
          Fix Version/s 0.92.2 [ 12319888 ]
          Jimmy Xiang made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              chunhui shen
              Reporter:
              chunhui shen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development