Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5073

Registered listeners not getting removed leading to memory leak in HBaseAdmin

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.90.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBaseAdmin apis like tableExists(), flush, split, closeRegion uses catalog tracker. Every time Root node tracker and meta node tracker are started and a listener is registered. But after the operations are performed the listeners are not getting removed. Hence if the admin apis are consistently used then it may lead to memory leak.

      1. HBASE-5073.patch
        2 kB
        ramkrishna.s.vasudevan

        Activity

        Hide
        ram_krish ramkrishna.s.vasudevan added a comment -

        This problem is not present in trunk.

        Show
        ram_krish ramkrishna.s.vasudevan added a comment - This problem is not present in trunk.
        Hide
        ram_krish ramkrishna.s.vasudevan added a comment -

        For branch patch

        Show
        ram_krish ramkrishna.s.vasudevan added a comment - For branch patch
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        +1 on patch, if tests pass.

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - +1 on patch, if tests pass.
        Hide
        stack stack added a comment -

        +1

        Show
        stack stack added a comment - +1
        Hide
        lhofhansl Lars Hofhansl added a comment -

        +1

        Maybe in another jira we should either disallow passing a Watcher (since unremovable listeners will be added to it), or clean up the listeners. That applies to 0.92 and trunk as well.

        Show
        lhofhansl Lars Hofhansl added a comment - +1 Maybe in another jira we should either disallow passing a Watcher (since unremovable listeners will be added to it), or clean up the listeners. That applies to 0.92 and trunk as well.
        Hide
        ram_krish ramkrishna.s.vasudevan added a comment -

        Tests are passing.

        Show
        ram_krish ramkrishna.s.vasudevan added a comment - Tests are passing.
        Hide
        zhihyu@ebaysf.com Ted Yu added a comment -

        Integrated to 0.90 branch

        Thanks for the patch, Ramkrishna.

        Thanks for the review, Stack and Lars

        Show
        zhihyu@ebaysf.com Ted Yu added a comment - Integrated to 0.90 branch Thanks for the patch, Ramkrishna. Thanks for the review, Stack and Lars
        Hide
        ram_krish ramkrishna.s.vasudevan added a comment -

        Committed to branch hence resolving.

        Show
        ram_krish ramkrishna.s.vasudevan added a comment - Committed to branch hence resolving.
        Hide
        lars_francke Lars Francke added a comment -

        This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

        Show
        lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          People

          • Assignee:
            ram_krish ramkrishna.s.vasudevan
            Reporter:
            ram_krish ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development