HBase
  1. HBase
  2. HBASE-5073

Registered listeners not getting removed leading to memory leak in HBaseAdmin

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.90.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBaseAdmin apis like tableExists(), flush, split, closeRegion uses catalog tracker. Every time Root node tracker and meta node tracker are started and a listener is registered. But after the operations are performed the listeners are not getting removed. Hence if the admin apis are consistently used then it may lead to memory leak.

      1. HBASE-5073.patch
        2 kB
        ramkrishna.s.vasudevan

        Activity

        ramkrishna.s.vasudevan created issue -
        Hide
        ramkrishna.s.vasudevan added a comment -

        This problem is not present in trunk.

        Show
        ramkrishna.s.vasudevan added a comment - This problem is not present in trunk.
        Hide
        ramkrishna.s.vasudevan added a comment -

        For branch patch

        Show
        ramkrishna.s.vasudevan added a comment - For branch patch
        ramkrishna.s.vasudevan made changes -
        Field Original Value New Value
        Attachment HBASE-5073.patch [ 12508063 ]
        Hide
        Ted Yu added a comment -

        +1 on patch, if tests pass.

        Show
        Ted Yu added a comment - +1 on patch, if tests pass.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Lars Hofhansl added a comment -

        +1

        Maybe in another jira we should either disallow passing a Watcher (since unremovable listeners will be added to it), or clean up the listeners. That applies to 0.92 and trunk as well.

        Show
        Lars Hofhansl added a comment - +1 Maybe in another jira we should either disallow passing a Watcher (since unremovable listeners will be added to it), or clean up the listeners. That applies to 0.92 and trunk as well.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Tests are passing.

        Show
        ramkrishna.s.vasudevan added a comment - Tests are passing.
        Hide
        Ted Yu added a comment -

        Integrated to 0.90 branch

        Thanks for the patch, Ramkrishna.

        Thanks for the review, Stack and Lars

        Show
        Ted Yu added a comment - Integrated to 0.90 branch Thanks for the patch, Ramkrishna. Thanks for the review, Stack and Lars
        Ted Yu made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.90.6 [ 12319200 ]
        Fix Version/s 0.90.5 [ 12317145 ]
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to branch hence resolving.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to branch hence resolving.
        ramkrishna.s.vasudevan made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7d 20h 17m 1 ramkrishna.s.vasudevan 28/Dec/11 02:24

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development