HBase
  1. HBase
  2. HBASE-4989

Metrics to measure sequential reads and random reads separately

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      The metric fsReadLatency records the number of sequential reads. The metric fsPreadLatency records the number of random reads.

      Description

      HBase does sequential reads for compactions and positional random reads for satisfying user's queries. It would be nice if we can measure their latencies separately. It is mostly the random reads that dominate a transactional workload.

      1. metrics1.txt
        6 kB
        dhruba borthakur

        Activity

        Hide
        dhruba borthakur added a comment -
        Show
        dhruba borthakur added a comment - Code here : https://reviews.facebook.net/D693
        Hide
        dhruba borthakur added a comment -

        Patchfor trunk.

        Show
        dhruba borthakur added a comment - Patchfor trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506971/metrics1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated -160 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestInstantSchemaChange
        org.apache.hadoop.hbase.client.TestAdmin

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/487//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/487//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/487//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506971/metrics1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -160 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestInstantSchemaChange org.apache.hadoop.hbase.client.TestAdmin Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/487//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/487//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/487//console This message is automatically generated.
        Hide
        stack added a comment -

        Applied to trunk. Thanks for patch Dhruba.

        Show
        stack added a comment - Applied to trunk. Thanks for patch Dhruba.
        Hide
        stack added a comment -

        Oh, the above hadoop-qa failures were because of 'too many files' – unrelated to this patch.

        Show
        stack added a comment - Oh, the above hadoop-qa failures were because of 'too many files' – unrelated to this patch.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #29 (See https://builds.apache.org/job/HBase-TRUNK-security/29/)
        HBASE-4989 Metrics to measure sequential reads and random reads separately

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #29 (See https://builds.apache.org/job/HBase-TRUNK-security/29/ ) HBASE-4989 Metrics to measure sequential reads and random reads separately stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2540 (See https://builds.apache.org/job/HBase-TRUNK/2540/)
        HBASE-4989 Metrics to measure sequential reads and random reads separately

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2540 (See https://builds.apache.org/job/HBase-TRUNK/2540/ ) HBASE-4989 Metrics to measure sequential reads and random reads separately stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
        Hide
        Phabricator added a comment -

        dhruba has closed the revision "[jira] HBASE-4989 Metrics to measure sequential reads and random reads separately".

        REVISION DETAIL
        https://reviews.facebook.net/D693

        To: stack, todd, Kannan, khemani, dhruba
        Cc: JIRA, todd, stack

        Show
        Phabricator added a comment - dhruba has closed the revision " [jira] HBASE-4989 Metrics to measure sequential reads and random reads separately". REVISION DETAIL https://reviews.facebook.net/D693 To: stack, todd, Kannan, khemani, dhruba Cc: JIRA, todd, stack

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development