[HBASE-4773] HBaseAdmin may leak ZooKeeper connections

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.90.4
• Fix Version/s: 0.90.6, 0.92.0
• Component/s: Client
• Assignee: xufeng
• Reporter: gaojinchao
• Due: 11/Nov/11
• Created: 11/Nov/11 09:23
• Updated: 20/Nov/15 11:54
• Resolved: 04/Jan/12 19:00

Description

When master crashs, HBaseAdmin will leaks ZooKeeper connections
I think we should close the zk connetion when throw MasterNotRunningException

public HBaseAdmin(Configuration c)
throws MasterNotRunningException, ZooKeeperConnectionException {
this.conf = HBaseConfiguration.create(c);
this.connection = HConnectionManager.getConnection(this.conf);
this.pause = this.conf.getLong("hbase.client.pause", 1000);
this.numRetries = this.conf.getInt("hbase.client.retries.number", 10);
this.retryLongerMultiplier = this.conf.getInt("hbase.client.retries.longer.multiplier", 10);

//we should add this code and close the zk connection
try

{ this.connection.getMaster(); }

catch(MasterNotRunningException e)

{ HConnectionManager.deleteConnection(conf, false); throw e; }

}