Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Show more detail on blockcache deployed in new BlockCache section under Tasks and above Regions; shows blockcache type, what for L1 and L2, help pointers, type-specific and L1/L2 stats as well as dumps of bucket/slab cache stats when bucket/slabs enabled. Keeps block cache age (works in Bucket and LruBlockCache, not for Slab). Adds JSON page with details on block caches and a facility for listing block cache content by file (useful finding hot files).
      Show
      Show more detail on blockcache deployed in new BlockCache section under Tasks and above Regions; shows blockcache type, what for L1 and L2, help pointers, type-specific and L1/L2 stats as well as dumps of bucket/slab cache stats when bucket/slabs enabled. Keeps block cache age (works in Bucket and LruBlockCache, not for Slab). Adds JSON page with details on block caches and a facility for listing block cache content by file (useful finding hot files).

      Description

      Summarized block-cache report for a RegionServer would be helpful. For example ...

      table1
      cf1 100 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
      cf2 200 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours

      table2
      cf1 75 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
      cf2 150 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours

      ... Etc.

      The current metrics list blockCacheSize and blockCacheFree, but there is no way to know what's in there. Any single block isn't really important, but the patterns of what CF/Table they came from, how big are they, and how long (on average) they've been in the cache, are important.

      No such interface exists in HRegionInterface. But I think it would be helpful from an operational perspective.

      Updated (7-29): Removing suggestion for UI. I would be happy just to get this report on a configured interval dumped to a log file.

      1. hbase_4089_blockcachereport.pdf
        145 kB
        Doug Meil
      2. java_blockcache_checkpoint_2011_08_11.patch
        13 kB
        Doug Meil
      3. 4089.wip.txt
        89 kB
        stack
      4. bc_l2_buckets.png
        140 kB
        stack
      5. bc_slabs.png
        110 kB
        stack
      6. bc_l1.png
        89 kB
        stack
      7. bc_stats.png
        109 kB
        stack
      8. bc_config.png
        121 kB
        stack
      9. bc_basic.png
        128 kB
        stack
      10. 4089.wip.v2.txt
        119 kB
        stack
      11. bc_slabs.png
        199 kB
        stack
      12. bc_buckets.png
        91 kB
        stack
      13. bc_showing_buckets_start.png
        50 kB
        stack
      14. bc_bucketcache.png
        98 kB
        stack
      15. 4089v3.txt
        147 kB
        stack
      16. 4089v4.txt
        149 kB
        stack
      17. 4089v6.txt
        151 kB
        stack
      18. 4089v7.txt
        151 kB
        stack
      19. 4089v7.txt
        151 kB
        stack
      20. 4089v8.txt
        151 kB
        stack

        Activity

        Hide
        Doug Meil added a comment -

        Regarding dumping the summary report to the log, I think exposing a public 'printSummary' (logSummary?) method on LruBlockCache would do it. Another thread can take care of the scheduling on how often the block cache summary should be run.

        Show
        Doug Meil added a comment - Regarding dumping the summary report to the log, I think exposing a public 'printSummary' (logSummary?) method on LruBlockCache would do it. Another thread can take care of the scheduling on how often the block cache summary should be run.
        Hide
        Doug Meil added a comment -

        If this approach is acceptable, probably should add this to the BlockCache interface. This is how the block cache is accessed.

        Show
        Doug Meil added a comment - If this approach is acceptable, probably should add this to the BlockCache interface. This is how the block cache is accessed.
        Hide
        Doug Meil added a comment -

        Adding writeup of use-cases and 1st-pass general design.

        Show
        Doug Meil added a comment - Adding writeup of use-cases and 1st-pass general design.
        Hide
        Jean-Daniel Cryans added a comment -

        Nice document Doug, it puts everyone else to shame

        I don't think we can expose those metrics through JMX/Ganglia/OpenTSDB as they will be changing a lot. It would be "doable" only if the regions and families never changed IMO. I'd prefer we concentrate on presenting this information from inside HBase.

        In the nice to haves I'd like to see:

        • Number of accesses/misses per block or family (could see what's hot, well cached, etc)
        • Total size of the family on disk (then you can tell what portion of the dataset you cached)

        Regarding the Writable question, you have to do that because it's required by Hadoop RPC. Since you are adding new infos, you'll have to implement it. Don't forget the default constructor!

        For the web UI, what about making the region name clickable?

        Show
        Jean-Daniel Cryans added a comment - Nice document Doug, it puts everyone else to shame I don't think we can expose those metrics through JMX/Ganglia/OpenTSDB as they will be changing a lot. It would be "doable" only if the regions and families never changed IMO. I'd prefer we concentrate on presenting this information from inside HBase. In the nice to haves I'd like to see: Number of accesses/misses per block or family (could see what's hot, well cached, etc) Total size of the family on disk (then you can tell what portion of the dataset you cached) Regarding the Writable question, you have to do that because it's required by Hadoop RPC. Since you are adding new infos, you'll have to implement it. Don't forget the default constructor! For the web UI, what about making the region name clickable?
        Hide
        Doug Meil added a comment -

        Thanks JD. I included the JMX/Ganglia/et al. because it came up as suggestions in the dist-list, but I really didn't see how it would fit with this type of usage reporting. I'm glad you came to the same conclusion!

        Show
        Doug Meil added a comment - Thanks JD. I included the JMX/Ganglia/et al. because it came up as suggestions in the dist-list, but I really didn't see how it would fit with this type of usage reporting. I'm glad you came to the same conclusion!
        Hide
        Andrew Purtell added a comment -

        Does that mean that BlockCacheSummary returned from BlockCache should implement writable, or is there another class that represents the BlockCacheSummary that implements Writable that has the same information

        Objects sent over RPC implement Writable directly, so by that convention BlockCacheSummary should implement Writable.

        Show
        Andrew Purtell added a comment - Does that mean that BlockCacheSummary returned from BlockCache should implement writable, or is there another class that represents the BlockCacheSummary that implements Writable that has the same information Objects sent over RPC implement Writable directly, so by that convention BlockCacheSummary should implement Writable.
        Hide
        Doug Meil added a comment -

        Ok, how about this for the next course of action:

        Subtask #1: implement basic summary in BlockCache/LruBlockCache, RS-API change, web-UI.

        Subtask #2: this is the "output to X" part of the ticket.

        I'll start with #1, hold off on #2 for now.

        Does that sound reasonable?

        Show
        Doug Meil added a comment - Ok, how about this for the next course of action: Subtask #1: implement basic summary in BlockCache/LruBlockCache, RS-API change, web-UI. Subtask #2: this is the "output to X" part of the ticket. I'll start with #1, hold off on #2 for now. Does that sound reasonable?
        Hide
        Jean-Daniel Cryans added a comment -

        +1

        Show
        Jean-Daniel Cryans added a comment - +1
        Hide
        Doug Meil added a comment -

        Hmmm.. started implementation and have been running other unit tests and getting more information on blockNames in the cache, and here's what they look like now: "8351478435190657655_0". That looks a lot more like a "block" than what I had documented in the writeup, but unfortunately I have nothing else to go on. Based on what I see, I need to do a reverse lookup in the catalog for the containing StoreFile (to hopefully get full-path, where I can get table/CF).

        Anybody know any easy way to do that?

        Show
        Doug Meil added a comment - Hmmm.. started implementation and have been running other unit tests and getting more information on blockNames in the cache, and here's what they look like now: "8351478435190657655_0". That looks a lot more like a "block" than what I had documented in the writeup, but unfortunately I have nothing else to go on. Based on what I see, I need to do a reverse lookup in the catalog for the containing StoreFile (to hopefully get full-path, where I can get table/CF). Anybody know any easy way to do that?
        Hide
        stack added a comment -

        Tell us more about this reverse lookup.... whats that going to look like? Are you sure what you are seeing is not a filename plus an offset?

        Show
        stack added a comment - Tell us more about this reverse lookup.... whats that going to look like? Are you sure what you are seeing is not a filename plus an offset?
        Hide
        Doug Meil added a comment -

        Let me back up a bit on this... what is the contract on the 'name' attribute in CachedBlock (the value class of the internal block cache map)? What is that supposed to be?

        Show
        Doug Meil added a comment - Let me back up a bit on this... what is the contract on the 'name' attribute in CachedBlock (the value class of the internal block cache map)? What is that supposed to be?
        Hide
        stack added a comment -

        I'd say the name just has to be guaranteed unique... short would be nice too.

        Currently name is made in here for both v1 and v2 hfiles:

          public static String getBlockCacheKey(String hfileName, long offset) {
            return hfileName + CACHE_KEY_SEPARATOR + offset;
          }
        

        The hfilename seems to depend on the fact storefile names are unique across hbase. They are made here using the 'name' part of the full storefile Path (from the AbstractHFileReader constructor):

        this.name = path.getName();

        Show
        stack added a comment - I'd say the name just has to be guaranteed unique... short would be nice too. Currently name is made in here for both v1 and v2 hfiles: public static String getBlockCacheKey( String hfileName, long offset) { return hfileName + CACHE_KEY_SEPARATOR + offset; } The hfilename seems to depend on the fact storefile names are unique across hbase. They are made here using the 'name' part of the full storefile Path (from the AbstractHFileReader constructor): this.name = path.getName();
        Hide
        Doug Meil added a comment -

        Ahhh.. ok, I get it. This... "8351478435190657655_0" ... makes sense now.

        Since the first part is a StoreFile, I can use directory paths to figure out which CF, which region, and which table this StoreFile belongs to because the directory structure is /table/region/cf/storefile. I'll basically construct a Map where the key is the hfileName (aka StoreFile) and the value is an object that contains table/cf (since that is the level that the report needs to roll up to).

        I'm currently not aware of any utility that has this kind of lookup, but I think I now understand how to build it.

        Show
        Doug Meil added a comment - Ahhh.. ok, I get it. This... "8351478435190657655_0" ... makes sense now. Since the first part is a StoreFile, I can use directory paths to figure out which CF, which region, and which table this StoreFile belongs to because the directory structure is /table/region/cf/storefile. I'll basically construct a Map where the key is the hfileName (aka StoreFile) and the value is an object that contains table/cf (since that is the level that the report needs to roll up to). I'm currently not aware of any utility that has this kind of lookup, but I think I now understand how to build it.
        Hide
        Doug Meil added a comment -

        Hey JD/Stack, can you guys sniff this patch? This is only a checkpoint - not the final product - but it actually works (I have a hacked up unit test that isn't in this patch). What I hope to be the hard-part hopefully (i.e., the summarization) is done, now it needs to be added to the RS API.

        Show
        Doug Meil added a comment - Hey JD/Stack, can you guys sniff this patch? This is only a checkpoint - not the final product - but it actually works (I have a hacked up unit test that isn't in this patch). What I hope to be the hard-part hopefully (i.e., the summarization) is done, now it needs to be added to the RS API.
        Hide
        Ming Ma added a comment -

        useful doc, Doug.

        It seems like this one, https://issues.apache.org/jira/browse/HBASE-4147, https://issues.apache.org/jira/browse/HBASE-4145 need some common infrastructure to log and analyze structured data.

        1. RS Web UI is useful. But that only provides the most recent value.

        2. As you mentioned in the doc, we can create a static metric for each combination of table and CF. That could end up with lots of metrics. Might not be ideal.

        3. How we plan to analyze the data is an important factor for the design.
        a. Is there a latency requirement? In a production system, it is better to get these reports sooner than later.
        b. Is it easy to do query and analysis on the data?, e.g., aggregate, max, etc.

        4. Some ideas along the line of custom output
        a. Can the log data be asynchronously uploaded to a special table in hbase? It might be a bit strange to upload data back to hbase. However, for performance, we can partition the special table into regions so that each region is colocated on the same RS where the log is generated; no automatic compaction, split, load balancing on the table.
        b. Upload the log to HDFS periodically. Run map reduce jobs to mine the data with a customized inputformat. This might be ok if there is no strong latency requirement.

        Show
        Ming Ma added a comment - useful doc, Doug. It seems like this one, https://issues.apache.org/jira/browse/HBASE-4147 , https://issues.apache.org/jira/browse/HBASE-4145 need some common infrastructure to log and analyze structured data. 1. RS Web UI is useful. But that only provides the most recent value. 2. As you mentioned in the doc, we can create a static metric for each combination of table and CF. That could end up with lots of metrics. Might not be ideal. 3. How we plan to analyze the data is an important factor for the design. a. Is there a latency requirement? In a production system, it is better to get these reports sooner than later. b. Is it easy to do query and analysis on the data?, e.g., aggregate, max, etc. 4. Some ideas along the line of custom output a. Can the log data be asynchronously uploaded to a special table in hbase? It might be a bit strange to upload data back to hbase. However, for performance, we can partition the special table into regions so that each region is colocated on the same RS where the log is generated; no automatic compaction, split, load balancing on the table. b. Upload the log to HDFS periodically. Run map reduce jobs to mine the data with a customized inputformat. This might be ok if there is no strong latency requirement.
        Hide
        Doug Meil added a comment -

        Yep, I logged HBASE-4147 and did that writeup too. Summarizing and periodically outputting data is a theme. I think that writing these summaries back into an hbase table is a good idea. I personally don't think this kind of data fits well into what are currently called 'metrics' which is much higher level.

        Show
        Doug Meil added a comment - Yep, I logged HBASE-4147 and did that writeup too. Summarizing and periodically outputting data is a theme. I think that writing these summaries back into an hbase table is a good idea. I personally don't think this kind of data fits well into what are currently called 'metrics' which is much higher level.
        Hide
        Jean-Daniel Cryans added a comment -

        Some comments on the patch:

        • Writables need a default constructor! See my 01/Aug/11 18:03 comment
        • About the style, I'd prefer you don't put extra white spaces like in this snippet:
          arg0.writeUTF( table );
          
        • Also pay attention to those lines > 80 chars.
        • Shouldn't the pattern in getBlockCacheSummary be a member of the class instead? (and still final)
        • Try to set the size of containers when you already know it, like at the end of getBlockCacheSummary
        Show
        Jean-Daniel Cryans added a comment - Some comments on the patch: Writables need a default constructor! See my 01/Aug/11 18:03 comment About the style, I'd prefer you don't put extra white spaces like in this snippet: arg0.writeUTF( table ); Also pay attention to those lines > 80 chars. Shouldn't the pattern in getBlockCacheSummary be a member of the class instead? (and still final) Try to set the size of containers when you already know it, like at the end of getBlockCacheSummary
        Hide
        Doug Meil added a comment -

        Thanks! I'll make the changes.

        re: "default constructor"
        Yep, you said that already. Doh! Although in my doh-fense I hadn't gotten to the RS-API yet.

        re: "Shouldn't the pattern in getBlockCacheSummary be a member of the class instead? (and still final)"
        I'm not sure I know what you mean...

        Show
        Doug Meil added a comment - Thanks! I'll make the changes. re: "default constructor" Yep, you said that already. Doh! Although in my doh-fense I hadn't gotten to the RS-API yet. re: "Shouldn't the pattern in getBlockCacheSummary be a member of the class instead? (and still final)" I'm not sure I know what you mean...
        Hide
        Jean-Daniel Cryans added a comment -

        Move this out of the method:

        final String pattern = "\\" + HFile.CACHE_KEY_SEPARATOR;
        
        Show
        Jean-Daniel Cryans added a comment - Move this out of the method: final String pattern = "\\" + HFile.CACHE_KEY_SEPARATOR;
        Hide
        Doug Meil added a comment -

        Sure thing. I didn't want it in the loop obviously, but it didn't seem like it was important enough to be permanently in memory in the block cache (although it's pretty small).

        Show
        Doug Meil added a comment - Sure thing. I didn't want it in the loop obviously, but it didn't seem like it was important enough to be permanently in memory in the block cache (although it's pretty small).
        Hide
        Lars Hofhansl added a comment -

        Doug, are you planning on finishing this?

        Show
        Lars Hofhansl added a comment - Doug, are you planning on finishing this?
        Hide
        Doug Meil added a comment -

        The sub-task HBASE-4200 was closed as a dup, what was the ticket that implemented that UI?

        Show
        Doug Meil added a comment - The sub-task HBASE-4200 was closed as a dup, what was the ticket that implemented that UI?
        Hide
        Doug Meil added a comment -

        Realistically, I don't think I can do the front-end work.

        Show
        Doug Meil added a comment - Realistically, I don't think I can do the front-end work.
        Hide
        Lars Hofhansl added a comment -

        Maybe I closed the sub task in error. Looking at the Web UI, I can see block cache statistics. But this is different. Should I reopen?

        Show
        Lars Hofhansl added a comment - Maybe I closed the sub task in error. Looking at the Web UI, I can see block cache statistics. But this is different. Should I reopen?
        Hide
        Doug Meil added a comment -

        Unless somebody already did the UI showing the details of the block cache report (by table, etc.) then it's not done.

        Show
        Doug Meil added a comment - Unless somebody already did the UI showing the details of the block cache report (by table, etc.) then it's not done.
        Hide
        stack added a comment -

        Let me take this over. The committed backend code, HBASE-4199, was never used. Let me pull it around and have it show in UI (Will hijack HBASE-4200 too). Let me make it work for bucketcache and lrublockcache at least doing something like the comment over in https://issues.apache.org/jira/browse/HBASE-4027?focusedCommentId=13068544&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13068544

        Show
        stack added a comment - Let me take this over. The committed backend code, HBASE-4199 , was never used. Let me pull it around and have it show in UI (Will hijack HBASE-4200 too). Let me make it work for bucketcache and lrublockcache at least doing something like the comment over in https://issues.apache.org/jira/browse/HBASE-4027?focusedCommentId=13068544&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13068544
        Hide
        stack added a comment -

        Can dump out a blockcache page that lists the BlockCaches involved. For the lrublockcache can dump out the metrics and a summary listing size, and histogram of block ages

        2014-05-23 14:40:10,399 INFO [main] hfile.TestBlockCacheSummary(66): hitCount=0, hitCachingCount=0, missCount=0, missCachingCount=0, evictionCount=0, evictedBlockCount=0
        2014-05-23 14:40:10,414 INFO [main] hfile.TestBlockCacheSummary(68): LruBlockCache Summary count=100, size=32800, mean age=1.24991E7, stddev age=3681288.5576173523, min age=1.1762E7, max age=4.8877E7, 95th percentile age=1.251815E7, 99th percentile age=4.8513689999999814E7

        Would follow the above with a list of files involved and per file a summary:

        2014-05-23 14:40:10,429 INFO [main] hfile.TestBlockCacheSummary(85): file=f, blockCount=100, blockCountData=100, size=32800

        Maybe the file summary is clickable and then you get listing of all blocks with offset into the file, size of block, age in nanos, and type:

        2014-05-23 14:40:10,428 INFO [main] hfile.TestBlockCacheSummary(80): offset=93, size=328, ageInNanos=11806000, priority=SINGLE, blockType=DATA

        You might in this screen get the full filename so you can find table and column family.

        Above is doable for the lrublockcache.

        For BucketCache, there is less info available. In this case we'd dump out a summary followed by stats per bucket from the bucketallocator.

        Show
        stack added a comment - Can dump out a blockcache page that lists the BlockCaches involved. For the lrublockcache can dump out the metrics and a summary listing size, and histogram of block ages 2014-05-23 14:40:10,399 INFO [main] hfile.TestBlockCacheSummary(66): hitCount=0, hitCachingCount=0, missCount=0, missCachingCount=0, evictionCount=0, evictedBlockCount=0 2014-05-23 14:40:10,414 INFO [main] hfile.TestBlockCacheSummary(68): LruBlockCache Summary count=100, size=32800, mean age=1.24991E7, stddev age=3681288.5576173523, min age=1.1762E7, max age=4.8877E7, 95th percentile age=1.251815E7, 99th percentile age=4.8513689999999814E7 Would follow the above with a list of files involved and per file a summary: 2014-05-23 14:40:10,429 INFO [main] hfile.TestBlockCacheSummary(85): file=f, blockCount=100, blockCountData=100, size=32800 Maybe the file summary is clickable and then you get listing of all blocks with offset into the file, size of block, age in nanos, and type: 2014-05-23 14:40:10,428 INFO [main] hfile.TestBlockCacheSummary(80): offset=93, size=328, ageInNanos=11806000, priority=SINGLE, blockType=DATA You might in this screen get the full filename so you can find table and column family. Above is doable for the lrublockcache. For BucketCache, there is less info available. In this case we'd dump out a summary followed by stats per bucket from the bucketallocator.
        Hide
        Andrew Purtell added a comment -

        +1, that would be a nice improvement

        Show
        Andrew Purtell added a comment - +1, that would be a nice improvement
        Hide
        stack added a comment -

        wip

        Make BlockCaches Iterable.

        Make it so can ask BlockCache if it has sub BlockCaches.

        Add tools that can do sums, report block types, and age histograms when passed block cache Iterators. Currently we report by file.

        Removed the unused BlockCacheColumnFamilySummary stuff.

        Made BlockPriority class since priority was in BucketCache and LruBlockCache.

        TODO: Build out cache stats so report by slab for SlabCache and by bucket for BucketCache.

        TODO: See if I can remove the hokey reporting thread that dumps into the logs every 5minutes the block cache 'status'.... see if can make data available via metrics and elsewise (Currently we launch a thread to report but logging is at DEBUG level so thread does nothing).

        TODO: add a few web pages to report this stuff on.

        Renamed CachedBlock as LruCachedBlock and then added new Interface CachedBlock that has info common to all BlockCache implementaitons.

        Renamed CachedBlockQueue as LruCachedBlockQueue

        Show
        stack added a comment - wip Make BlockCaches Iterable. Make it so can ask BlockCache if it has sub BlockCaches. Add tools that can do sums, report block types, and age histograms when passed block cache Iterators. Currently we report by file. Removed the unused BlockCacheColumnFamilySummary stuff. Made BlockPriority class since priority was in BucketCache and LruBlockCache. TODO: Build out cache stats so report by slab for SlabCache and by bucket for BucketCache. TODO: See if I can remove the hokey reporting thread that dumps into the logs every 5minutes the block cache 'status'.... see if can make data available via metrics and elsewise (Currently we launch a thread to report but logging is at DEBUG level so thread does nothing). TODO: add a few web pages to report this stuff on. Renamed CachedBlock as LruCachedBlock and then added new Interface CachedBlock that has info common to all BlockCache implementaitons. Renamed CachedBlockQueue as LruCachedBlockQueue
        Hide
        stack added a comment -

        Some pictures of what I have so far.

        I've added a section to the RS UI called Block Cache.

        You tab over 'basic info', 'configuration', 'stats', 'l1 stats', and 'l2 stats'. If no l2, says 'no l2 deployed'. If DoubleBlockCache or CombinedBlockCache, shows these as implementations and then detail on the LruBlockCache L1 and the SlabCache or BucketCache L2s. Shows Slabs and their stats if SlabCache. Shows buckets and their stats if it is deployed.

        Should be general enough to entertain other deploy types.

        TODO: expose these details to monitoring tools; though expensive to calculate I can imagine folks wanting to study them over periods of investigation or setup. Could add json view here or probably better, make real metrics of them (might be too much).

        TODO: Finish up the blocks by files page; good for geting rough view on what files are hot and how hot. The info is there, just need to add a template.

        Show
        stack added a comment - Some pictures of what I have so far. I've added a section to the RS UI called Block Cache. You tab over 'basic info', 'configuration', 'stats', 'l1 stats', and 'l2 stats'. If no l2, says 'no l2 deployed'. If DoubleBlockCache or CombinedBlockCache, shows these as implementations and then detail on the LruBlockCache L1 and the SlabCache or BucketCache L2s. Shows Slabs and their stats if SlabCache. Shows buckets and their stats if it is deployed. Should be general enough to entertain other deploy types. TODO: expose these details to monitoring tools; though expensive to calculate I can imagine folks wanting to study them over periods of investigation or setup. Could add json view here or probably better, make real metrics of them (might be too much). TODO: Finish up the blocks by files page; good for geting rough view on what files are hot and how hot. The info is there, just need to add a template.
        Hide
        stack added a comment -

        Oh, other TODOs: put up on real cluster and tune some of the numbers reported.

        Show
        stack added a comment - Oh, other TODOs: put up on real cluster and tune some of the numbers reported.
        Hide
        stack added a comment -

        wip v2.

        Show
        stack added a comment - wip v2.
        Hide
        stack added a comment -

        More pictures including some showing JSON dumps of block cache content (including bucket state if BucketCache and slabs if SlabCache) – and listings by file of block cache content (in JSON).

        Show
        stack added a comment - More pictures including some showing JSON dumps of block cache content (including bucket state if BucketCache and slabs if SlabCache) – and listings by file of block cache content (in JSON).
        Hide
        stack added a comment -

        Tried this patch up on cluster. Basically works. SlabCache numbers are odd. Eviction counts need better description. Here is list of changes

        Fix capitalization in web page top navbar.
        
        Add two templates, one to do block cache tabs and then another to
        do JSON views on block cache.
        
        Hook them up in RSStatusTmpl.
        
        In BlockCache remove getEvictedCount.  Redundant with same method
        in CacheStats.  Make BlockCache implement CachedBlock iterator.
        Allow implementations return L1 and L2 if present.
        
        Remove old BlockCacheColumnFamilySummary and supporting classes
        and tests.  Unused.  Not hooked up.
        Heavyweight doing filter of hdfs contents to find file names.
        
        Add a BlockCacheUtil that has aggregating functions, toString
        and toJSON methods.
        
        Make common BlockPriority class rather than dup enums
        
        Renamed CachedBlock as LruCachedBlock and added CachedBlock
        as Interface.
        
        Renamed CachedBlockQueue as LruCachedBlockQueue.
        
        Adds a cache reporting test but has few asserts; exercises, 
        doesn't confirm.
        
        
        Show
        stack added a comment - Tried this patch up on cluster. Basically works. SlabCache numbers are odd. Eviction counts need better description. Here is list of changes Fix capitalization in web page top navbar. Add two templates, one to do block cache tabs and then another to do JSON views on block cache. Hook them up in RSStatusTmpl. In BlockCache remove getEvictedCount. Redundant with same method in CacheStats. Make BlockCache implement CachedBlock iterator. Allow implementations return L1 and L2 if present. Remove old BlockCacheColumnFamilySummary and supporting classes and tests. Unused. Not hooked up. Heavyweight doing filter of hdfs contents to find file names. Add a BlockCacheUtil that has aggregating functions, toString and toJSON methods. Make common BlockPriority class rather than dup enums Renamed CachedBlock as LruCachedBlock and added CachedBlock as Interface. Renamed CachedBlockQueue as LruCachedBlockQueue. Adds a cache reporting test but has few asserts; exercises, doesn't confirm.
        Hide
        stack added a comment -

        try hadoopqa

        Show
        stack added a comment - try hadoopqa
        Hide
        stack added a comment -
        Show
        stack added a comment - rb is up here https://reviews.apache.org/r/22299/
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648605/4089v3.txt
        against trunk revision .
        ATTACHMENT ID: 12648605

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + String bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("
        .", "/") + ".html";
        + <& bc_l1; bc = cacheConfig.getBlockCache().getBlockCaches() != null? cacheConfig.getBlockCache().getBlockCaches()[0]: cacheConfig.getBlockCache(); &>
        + <& bc_l2; bc = cacheConfig.getBlockCache().getBlockCaches() != null && cacheConfig.getBlockCache().getBlockCaches().length > 1 ? cacheConfig.getBlockCache().getBlockCaches()[1]: null; &>
        + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll("
        .", "/") + ".html";
        + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll("
        .", "/") + ".html";
        +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestRSStatusServlet

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648605/4089v3.txt against trunk revision . ATTACHMENT ID: 12648605 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + String bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll(" .", "/") + ".html"; + <& bc_l1; bc = cacheConfig.getBlockCache().getBlockCaches() != null? cacheConfig.getBlockCache().getBlockCaches() [0] : cacheConfig.getBlockCache(); &> + <& bc_l2; bc = cacheConfig.getBlockCache().getBlockCaches() != null && cacheConfig.getBlockCache().getBlockCaches().length > 1 ? cacheConfig.getBlockCache().getBlockCaches() [1] : null; &> + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll(" .", "/") + ".html"; + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll(" .", "/") + ".html"; +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td> +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestRSStatusServlet Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9702//console This message is automatically generated.
        Hide
        stack added a comment -

        Fix unit test failure. The long lines in the jamon templates are hard to avoid.

        Show
        stack added a comment - Fix unit test failure. The long lines in the jamon templates are hard to avoid.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648656/4089v4.txt
        against trunk revision .
        ATTACHMENT ID: 12648656

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("
        .", "/") + ".html";
        + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches();
        + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll("
        .", "/") + ".html";
        + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll("
        .", "/") + ".html";
        +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td>

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648656/4089v4.txt against trunk revision . ATTACHMENT ID: 12648656 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll(" .", "/") + ".html"; + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches(); + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll(" .", "/") + ".html"; + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll(" .", "/") + ".html"; +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td> +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9707//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        This is fantastic. I skimmed the jamon changes on RB and the attached snaps look good.

        IMO the line length warnings in the templates can be ignored.

        Please check the javadoc warn isn't related to this change. Otherwise +1

        The code changes are all on Private audience classes. CachedBlock is converted from a class to an interface, but only affected code is all internal. Can we have this in 0.98?

        Show
        Andrew Purtell added a comment - This is fantastic. I skimmed the jamon changes on RB and the attached snaps look good. IMO the line length warnings in the templates can be ignored. Please check the javadoc warn isn't related to this change. Otherwise +1 The code changes are all on Private audience classes. CachedBlock is converted from a class to an interface, but only affected code is all internal. Can we have this in 0.98?
        Hide
        stack added a comment -

        Fix a NPE over in SlabCache. Exclude age info on SlabCache because it doesn't support it. Add help note to that effect explaining why not present. Do similar w/ help note on BucketCache that it doesn't distingush DATA blocks.

        Misc clean up.

        Show
        stack added a comment - Fix a NPE over in SlabCache. Exclude age info on SlabCache because it doesn't support it. Add help note to that effect explaining why not present. Do similar w/ help note on BucketCache that it doesn't distingush DATA blocks. Misc clean up.
        Hide
        stack added a comment -

        Updated rb w/ v6.

        Show
        stack added a comment - Updated rb w/ v6.
        Hide
        stack added a comment -

        Andrew Purtell Sorry, yeah, this v6 should get the javadoc. It should go into 0.98. Thanks for the +1. Will commit if v6 makes it (Nick Dimiduk – you up or a looksee?)

        Show
        stack added a comment - Andrew Purtell Sorry, yeah, this v6 should get the javadoc. It should go into 0.98. Thanks for the +1. Will commit if v6 makes it ( Nick Dimiduk – you up or a looksee?)
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648698/4089v6.txt
        against trunk revision .
        ATTACHMENT ID: 12648698

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("
        .", "/") + ".html";
        + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches();
        + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll("
        .", "/") + ".html";
        + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll("
        .", "/") + ".html";
        +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td>

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestMultiParallel

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648698/4089v6.txt against trunk revision . ATTACHMENT ID: 12648698 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll(" .", "/") + ".html"; + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches(); + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll(" .", "/") + ".html"; + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll(" .", "/") + ".html"; +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td> +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9711//console This message is automatically generated.
        Hide
        stack added a comment -

        Fix one javadoc issue.

        Show
        stack added a comment - Fix one javadoc issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648752/4089v7.txt
        against trunk revision .
        ATTACHMENT ID: 12648752

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("
        .", "/") + ".html";
        + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches();
        + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll("
        .", "/") + ".html";
        + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll("
        .", "/") + ".html";
        +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td>

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s):

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648752/4089v7.txt against trunk revision . ATTACHMENT ID: 12648752 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll(" .", "/") + ".html"; + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches(); + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll(" .", "/") + ".html"; + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll(" .", "/") + ".html"; +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td> +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9714//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648783/4089v7.txt
        against trunk revision .
        ATTACHMENT ID: 12648783

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 24 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll("
        .", "/") + ".html";
        + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches();
        + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll("
        .", "/") + ".html";
        + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll("
        .", "/") + ".html";
        +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
        + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td>

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648783/4089v7.txt against trunk revision . ATTACHMENT ID: 12648783 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 24 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + bcUrl = "http://hbase.apache.org/devapidocs/" + bc.getClass().getName().replaceAll(" .", "/") + ".html"; + BlockCache [] bcs = cacheConfig == null? null: cacheConfig.getBlockCache() == null? null: cacheConfig.getBlockCache().getBlockCaches(); + bcl1Url = "http://hbase.apache.org/devapidocs/" + bcl1.getClass().getName().replaceAll(" .", "/") + ".html"; + bcl2Url = "http://hbase.apache.org/devapidocs/" + bcl2.getClass().getName().replaceAll(" .", "/") + ".html"; +<p>See <a href="http://hbase.apache.org/book.html#block.cache">Block Cache</a> in the HBase Reference Guide for help.</p> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td> + <td><% StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getMissCount()) %></td> +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9716//console This message is automatically generated.
        Hide
        Nick Dimiduk added a comment -

        SlabCache numbers are odd.

        I've noticed this in the past; don't really trust its metrics. I think it's because DoubleBlockCache caches twice, and metrics are all sums.

        Added a couple comments on rb; nothing major. Really nice addition, +1

        Show
        Nick Dimiduk added a comment - SlabCache numbers are odd. I've noticed this in the past; don't really trust its metrics. I think it's because DoubleBlockCache caches twice, and metrics are all sums. Added a couple comments on rb; nothing major. Really nice addition, +1
        Hide
        stack added a comment -

        Version which incorporates Nick Dimiduk feedback.

        Show
        stack added a comment - Version which incorporates Nick Dimiduk feedback.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5189 (See https://builds.apache.org/job/HBase-TRUNK/5189/)
        HBASE-4089 blockCache contents report (stack: rev 5851a064120634f8572a39a3d51afb4d8fc66a10)

        • pom.xml
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java
        • hbase-server/src/main/resources/hbase-webapps/master/table.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
        • hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
        • hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        • hbase-server/src/main/resources/hbase-webapps/master/zk.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5189 (See https://builds.apache.org/job/HBase-TRUNK/5189/ ) HBASE-4089 blockCache contents report (stack: rev 5851a064120634f8572a39a3d51afb4d8fc66a10) pom.xml hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java hbase-server/src/main/resources/hbase-webapps/master/table.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheConfig.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon hbase-server/src/main/resources/hbase-webapps/master/zk.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheReporting.java
        Hide
        Mikhail Antonov added a comment -

        Btw, is that something you guys have seen running org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testBucketCache as part of whole suite (when I run individual test locally, it passes)? Not sure if that's my local issue.

        java.lang.NullPointerException
        at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:386)
        at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:79)
        at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.addDataAndHits(TestBlockCacheReporting.java:66)
        at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testBucketCache(TestBlockCacheReporting.java:98)

        Show
        Mikhail Antonov added a comment - Btw, is that something you guys have seen running org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testBucketCache as part of whole suite (when I run individual test locally, it passes)? Not sure if that's my local issue. java.lang.NullPointerException at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:386) at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:79) at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.addDataAndHits(TestBlockCacheReporting.java:66) at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testBucketCache(TestBlockCacheReporting.java:98)
        Hide
        stack added a comment -

        How you get the NPE Mikhail Antonov? It happens when you run the suite? If I run the single test it seems to pass fine and passed above for the hadoopqa run. That said, there is something here for sure if you are seeing a regular failure.

        Show
        stack added a comment - How you get the NPE Mikhail Antonov ? It happens when you run the suite? If I run the single test it seems to pass fine and passed above for the hadoopqa run. That said, there is something here for sure if you are seeing a regular failure.
        Hide
        Mikhail Antonov added a comment -

        It actually happens on my jenkins (centos 6.4) which builds ASF master, cloning from https://git-wip-us.apache.org/repos/asf/hbase.git using simply 'mvn test'. I can reproduce it every time now (wiping out workspace from jenkins didn't help). So I'm just wondering if others ever seen this - if not, apparently it's something mine, local.

        Show
        Mikhail Antonov added a comment - It actually happens on my jenkins (centos 6.4) which builds ASF master, cloning from https://git-wip-us.apache.org/repos/asf/hbase.git using simply 'mvn test'. I can reproduce it every time now (wiping out workspace from jenkins didn't help). So I'm just wondering if others ever seen this - if not, apparently it's something mine, local.
        Hide
        stack added a comment -

        Mikhail Antonov Let me try.....

        Show
        stack added a comment - Mikhail Antonov Let me try.....
        Hide
        stack added a comment -

        Test suite passes on macosx. Trying elsewhere too. May be a race in here:

                  CacheableDeserializer<Cacheable> deserializer =
                    bucketEntry.deserializerReference(this.deserialiserMap);
                  Cacheable cachedBlock = deserializer.deserialize(bb, true);
        
        Show
        stack added a comment - Test suite passes on macosx. Trying elsewhere too. May be a race in here: CacheableDeserializer<Cacheable> deserializer = bucketEntry.deserializerReference( this .deserialiserMap); Cacheable cachedBlock = deserializer.deserialize(bb, true );
        Hide
        Misty Stanley-Jones added a comment -

        Does this JIRA address or relate to https://issues.apache.org/jira/browse/HBASE-8315?

        Show
        Misty Stanley-Jones added a comment - Does this JIRA address or relate to https://issues.apache.org/jira/browse/HBASE-8315?
        Hide
        stack added a comment -

        Does this JIRA address or relate to https://issues.apache.org/jira/browse/HBASE-8315?

        Misty Stanley-Jones It does with some minor mods commtted against HBASE-8315

        Show
        stack added a comment - Does this JIRA address or relate to https://issues.apache.org/jira/browse/HBASE-8315? Misty Stanley-Jones It does with some minor mods commtted against HBASE-8315
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #345 (See https://builds.apache.org/job/HBase-0.98/345/)
        HBASE-11366 Backport HBASE-4089 (block cache contents report UI) to 0.98 (stack: rev da94cd398f9a0b1dc8d601a894314559e4f0939f)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
        • pom.xml
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java
        • hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java
        • hbase-server/src/main/resources/hbase-webapps/master/zk.jsp
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
        • hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
        • hbase-server/src/main/resources/hbase-webapps/master/table.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #345 (See https://builds.apache.org/job/HBase-0.98/345/ ) HBASE-11366 Backport HBASE-4089 (block cache contents report UI) to 0.98 (stack: rev da94cd398f9a0b1dc8d601a894314559e4f0939f) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java pom.xml hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java hbase-server/src/main/resources/hbase-webapps/master/zk.jsp hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon hbase-server/src/main/resources/hbase-webapps/master/table.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #326 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/326/)
        HBASE-11366 Backport HBASE-4089 (block cache contents report UI) to 0.98 (stack: rev da94cd398f9a0b1dc8d601a894314559e4f0939f)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java
        • hbase-server/src/main/resources/hbase-webapps/master/table.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java
        • hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java
        • hbase-server/src/main/resources/hbase-webapps/master/zk.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java
        • hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp
        • hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
        • hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
        • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon
        • pom.xml
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #326 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/326/ ) HBASE-11366 Backport HBASE-4089 (block cache contents report UI) to 0.98 (stack: rev da94cd398f9a0b1dc8d601a894314559e4f0939f) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlock.java hbase-server/src/main/resources/hbase-webapps/master/table.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheKey.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCacheStats.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/RandomSeek.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileIOEngine.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockPriority.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/DoubleBlockCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSStatusServlet.java hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java hbase-server/src/main/resources/hbase-webapps/master/zk.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockCacheColumnFamilySummary.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCachedBlockQueue.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheViewTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlock.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CachedBlockQueue.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCachesIterator.java hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java hbase-server/src/main/resources/hbase-webapps/master/tablesDetailed.jsp hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/StateDumpServlet.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon pom.xml hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileBlockCacheSummary.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            stack
            Reporter:
            Doug Meil
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development