Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
0.90.3
-
None
-
None
Description
Is there a good reason to believe that caching blocks during compactions is beneficial? Currently, if block cache is enabled on a certain family, then every time it's compacted, we load all of its blocks into the (LRU) cache, at the expense of the legitimately hot ones.
As a matter of fact, this concern was raised earlier in HBASE-1597, which rightly points out that, "we should not bog down the LRU with unneccessary blocks" during compaction. Even though that issue has been marked as "fixed", it looks like it ought to be reopened.
Should we err on the side of caution and not cache blocks during compactions period (as illustrated in the attached patch)? Or, can we be selectively aggressive about what blocks do get cached during compaction (e.g., only cache those blocks from the recent files)?
Attachments
Attachments
Issue Links
- is part of
-
HBASE-5230 Ensure compactions do not cache-on-write data blocks
- Closed
- relates to
-
HBASE-1597 Prevent unnecessary caching of blocks during compactions
- Closed