Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-3935

HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      This patch removed the storefile_index_size_MB in protobuf. It will cause the value of storefile_index_size_MB is zero if user still use hbase-client 1.x.

      Description

      Related to HBASE-3927, Matt proposed changing HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see the size of small store file index.

      1. HBASE-3935.master.v0.patch
        4 kB
        Andy Yang
      2. HBASE-3935.branch-2.v6.patch
        21 kB
        Andy Yang
      3. HBASE-3935.branch-2.v5.patch
        21 kB
        Andy Yang
      4. HBASE-3935.branch-2.v4.patch
        21 kB
        Andy Yang
      5. HBASE-3935.branch-2.v3.patch
        21 kB
        Andy Yang
      6. HBASE-3935.branch-2.v2.patch
        18 kB
        Andy Yang
      7. HBASE-3935.branch-2.v1.patch
        4 kB
        Andy Yang
      8. HBASE-3935.branch-2.v0.patch
        4 kB
        Andy Yang

        Activity

        Hide
        lhofhansl Lars Hofhansl added a comment -

        In RegionServerMetrics I still see storefileIndexSizeMB, but in the RegionServer UI I am shown KB.

        Show
        lhofhansl Lars Hofhansl added a comment - In RegionServerMetrics I still see storefileIndexSizeMB, but in the RegionServer UI I am shown KB.
        Hide
        Jan Hentschel Jan Hentschel added a comment -

        HServerLoad seems to don't exist anymore. This ticket can probably be closed.

        Show
        Jan Hentschel Jan Hentschel added a comment - HServerLoad seems to don't exist anymore. This ticket can probably be closed.
        Hide
        andy7904 Andy Yang added a comment -

        I can do this, could give the ticket to me?

        Show
        andy7904 Andy Yang added a comment - I can do this, could give the ticket to me?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HBASE-3935 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



        Subsystem Report/Notes
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883872/HBASE-3935.master.v0.patch
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8327/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HBASE-3935 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883872/HBASE-3935.master.v0.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8327/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 36s Maven dependency ordering for branch
        +1 mvninstall 4m 31s branch-2 passed
        +1 compile 1m 11s branch-2 passed
        +1 checkstyle 1m 1s branch-2 passed
        +1 mvneclipse 0m 32s branch-2 passed
        +1 findbugs 4m 35s branch-2 passed
        +1 javadoc 1m 3s branch-2 passed
        0 mvndep 0m 20s Maven dependency ordering for patch
        +1 mvninstall 1m 24s the patch passed
        +1 compile 1m 16s the patch passed
        +1 javac 1m 16s the patch passed
        +1 checkstyle 0m 57s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 39m 36s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 findbugs 3m 48s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 2m 24s hbase-client in the patch passed.
        -1 unit 19m 33s hbase-server in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        85m 12s



        Reason Tests
        Failed junit tests hadoop.hbase.TestServerLoad



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883877/HBASE-3935.branch-2.v0.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux 5c419c186a28 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision branch-2 / 95bc464
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/8329/artifact/patchprocess/patch-unit-hbase-server.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8329/testReport/
        modules C: hbase-client hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8329/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 4m 31s branch-2 passed +1 compile 1m 11s branch-2 passed +1 checkstyle 1m 1s branch-2 passed +1 mvneclipse 0m 32s branch-2 passed +1 findbugs 4m 35s branch-2 passed +1 javadoc 1m 3s branch-2 passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 1m 16s the patch passed +1 javac 1m 16s the patch passed +1 checkstyle 0m 57s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 39m 36s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 3m 48s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 2m 24s hbase-client in the patch passed. -1 unit 19m 33s hbase-server in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 85m 12s Reason Tests Failed junit tests hadoop.hbase.TestServerLoad Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883877/HBASE-3935.branch-2.v0.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 5c419c186a28 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 95bc464 Default Java 1.8.0_144 findbugs v3.1.0-RC3 unit https://builds.apache.org/job/PreCommit-HBASE-Build/8329/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8329/testReport/ modules C: hbase-client hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8329/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chia7712 Chia-Ping Tsai added a comment -
        -      storefileSizeMB += rl.getStorefileSizeMB();
        +      storefileSizeKB += rl.getStorefileSizeMB()*1024;
        

        As i see it, using MB is fine for storefile size.

        The issue we need to address is "storefile index". BTW, changing the value of load on client is incorrect way. It seems to me that the following changes are required for this issue.

        1. We should change the metrics in HRegionServer. see createRegionLoad#createRegionLoad
            RegionLoad createRegionLoad(final Region r, RegionLoad.Builder regionLoadBldr,
                RegionSpecifier.Builder regionSpecifier) throws IOException {
              byte[] name = r.getRegionInfo().getRegionName();
              int stores = 0;
              int storefiles = 0;
              int storeUncompressedSizeMB = 0;
              int storefileSizeMB = 0;
              int memstoreSizeMB = (int) (r.getMemstoreSize() / 1024 / 1024);
              int storefileIndexSizeMB = 0;
              int rootIndexSizeKB = 0;
              int totalStaticIndexSizeKB = 0;
              int totalStaticBloomSizeKB = 0;
              long totalCompactingKVs = 0;
              long currentCompactedKVs = 0;
              List<Store> storeList = r.getStores();
              stores += storeList.size();
              for (Store store : storeList) {
                storefiles += store.getStorefilesCount();
                storeUncompressedSizeMB += (int) (store.getStoreSizeUncompressed() / 1024 / 1024);
                storefileSizeMB += (int) (store.getStorefilesSize() / 1024 / 1024);
                storefileIndexSizeMB += (int) (store.getStorefilesIndexSize() / 1024 / 1024);
          
        2. the ClusterStatut.proto need to replace uint32 storefile_index_size_MB by uint64 storefile_index_size_KB
        3. int ServerLoad#getStorefileIndexSizeMB -> long ServerLoad#getStorefileIndexSizeKB
        4. ServerLoad.storefileSizeMB -> ServerLoad.storefileSizeKB. Also, the type should be changed from int to long
        5. ServerLoad#getStorefileSizeInMB return ServerLoad#getStorefileIndexSizeKB / 1024
        Show
        chia7712 Chia-Ping Tsai added a comment - - storefileSizeMB += rl.getStorefileSizeMB(); + storefileSizeKB += rl.getStorefileSizeMB()*1024; As i see it, using MB is fine for storefile size. The issue we need to address is "storefile index". BTW, changing the value of load on client is incorrect way. It seems to me that the following changes are required for this issue. We should change the metrics in HRegionServer. see createRegionLoad#createRegionLoad RegionLoad createRegionLoad( final Region r, RegionLoad.Builder regionLoadBldr, RegionSpecifier.Builder regionSpecifier) throws IOException { byte [] name = r.getRegionInfo().getRegionName(); int stores = 0; int storefiles = 0; int storeUncompressedSizeMB = 0; int storefileSizeMB = 0; int memstoreSizeMB = ( int ) (r.getMemstoreSize() / 1024 / 1024); int storefileIndexSizeMB = 0; int rootIndexSizeKB = 0; int totalStaticIndexSizeKB = 0; int totalStaticBloomSizeKB = 0; long totalCompactingKVs = 0; long currentCompactedKVs = 0; List<Store> storeList = r.getStores(); stores += storeList.size(); for (Store store : storeList) { storefiles += store.getStorefilesCount(); storeUncompressedSizeMB += ( int ) (store.getStoreSizeUncompressed() / 1024 / 1024); storefileSizeMB += ( int ) (store.getStorefilesSize() / 1024 / 1024); storefileIndexSizeMB += ( int ) (store.getStorefilesIndexSize() / 1024 / 1024); the ClusterStatut.proto need to replace uint32 storefile_index_size_MB by uint64 storefile_index_size_KB int ServerLoad#getStorefileIndexSizeMB -> long ServerLoad#getStorefileIndexSizeKB ServerLoad.storefileSizeMB -> ServerLoad.storefileSizeKB. Also, the type should be changed from int to long ServerLoad#getStorefileSizeInMB return ServerLoad#getStorefileIndexSizeKB / 1024
        Hide
        andy7904 Andy Yang added a comment - - edited

        Chia-Ping Tsai , thank for the feedback.

        Show
        andy7904 Andy Yang added a comment - - edited Chia-Ping Tsai , thank for the feedback.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 4m 43s branch-2 passed
        +1 compile 0m 55s branch-2 passed
        +1 checkstyle 0m 48s branch-2 passed
        +1 mvneclipse 0m 25s branch-2 passed
        +1 findbugs 2m 49s branch-2 passed
        +1 javadoc 0m 44s branch-2 passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 55s the patch passed
        +1 javac 0m 55s the patch passed
        +1 checkstyle 0m 47s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 34m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 findbugs 3m 33s the patch passed
        +1 javadoc 0m 54s the patch passed
        +1 unit 2m 32s hbase-client in the patch passed.
        +1 unit 92m 33s hbase-server in the patch passed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        150m 1s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883900/HBASE-3935.branch-2.v1.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
        uname Linux d7f6c3bae1af 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-2 / 6db3d81
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8331/testReport/
        modules C: hbase-client hbase-server U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8331/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 4m 43s branch-2 passed +1 compile 0m 55s branch-2 passed +1 checkstyle 0m 48s branch-2 passed +1 mvneclipse 0m 25s branch-2 passed +1 findbugs 2m 49s branch-2 passed +1 javadoc 0m 44s branch-2 passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 0m 55s the patch passed +1 javac 0m 55s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 34m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 3m 33s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 2m 32s hbase-client in the patch passed. +1 unit 92m 33s hbase-server in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 150m 1s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883900/HBASE-3935.branch-2.v1.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux d7f6c3bae1af 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-2 / 6db3d81 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8331/testReport/ modules C: hbase-client hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8331/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 3m 42s branch-2 passed
        +1 compile 1m 57s branch-2 passed
        +1 checkstyle 1m 59s branch-2 passed
        +1 mvneclipse 0m 56s branch-2 passed
        +1 findbugs 6m 23s branch-2 passed
        +1 javadoc 1m 16s branch-2 passed
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 2m 13s the patch passed
        +1 compile 1m 57s the patch passed
        +1 cc 1m 57s the patch passed
        +1 javac 1m 57s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvneclipse 0m 56s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 31m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 30s the patch passed
        +1 findbugs 8m 29s the patch passed
        -1 javadoc 0m 22s hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 unit 0m 29s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 24s hbase-protocol in the patch passed.
        +1 unit 2m 50s hbase-client in the patch passed.
        -1 unit 19m 16s hbase-server in the patch failed.
        -1 unit 1m 14s hbase-rest in the patch failed.
        +1 asflicense 0m 42s The patch does not generate ASF License warnings.
        91m 44s



        Reason Tests
        Failed junit tests hadoop.hbase.TestServerLoad
          hadoop.hbase.rest.model.TestStorageClusterStatusModel



        Subsystem Report/Notes
        Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883951/HBASE-3935.branch-2.v2.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux 518202c5eafa 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision branch-2 / 6db3d81
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/diff-javadoc-javadoc-hbase-rest.txt
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/patch-unit-hbase-server.txt
        unit https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/patch-unit-hbase-rest.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8344/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8344/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 3m 42s branch-2 passed +1 compile 1m 57s branch-2 passed +1 checkstyle 1m 59s branch-2 passed +1 mvneclipse 0m 56s branch-2 passed +1 findbugs 6m 23s branch-2 passed +1 javadoc 1m 16s branch-2 passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 13s the patch passed +1 compile 1m 57s the patch passed +1 cc 1m 57s the patch passed +1 javac 1m 57s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvneclipse 0m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 31m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 30s the patch passed +1 findbugs 8m 29s the patch passed -1 javadoc 0m 22s hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 unit 0m 29s hbase-protocol-shaded in the patch passed. +1 unit 0m 24s hbase-protocol in the patch passed. +1 unit 2m 50s hbase-client in the patch passed. -1 unit 19m 16s hbase-server in the patch failed. -1 unit 1m 14s hbase-rest in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 91m 44s Reason Tests Failed junit tests hadoop.hbase.TestServerLoad   hadoop.hbase.rest.model.TestStorageClusterStatusModel Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883951/HBASE-3935.branch-2.v2.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux 518202c5eafa 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 6db3d81 Default Java 1.8.0_144 findbugs v3.1.0-RC3 javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/diff-javadoc-javadoc-hbase-rest.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/8344/artifact/patchprocess/patch-unit-hbase-rest.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8344/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8344/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chia7712 Chia-Ping Tsai added a comment -
        -  public int getStorefileIndexSizeMB() {
        -    return regionLoadPB.getStorefileIndexSizeMB();
        +  public long getStorefileIndexSizeKB() {
        +    return regionLoadPB.getStorefileIndexSizeKB();
        

        The RegionLoad is exposed as IA.Public, so we can't remove the APIs without the Deprecate. The getStorefileIndexSizeMB() should be reserved and deprecated.

        +    return (int) getStorefileIndexSizeKB() / 1024;
        

        It will be more precise to perform division before type cast.

        Show
        chia7712 Chia-Ping Tsai added a comment - - public int getStorefileIndexSizeMB() { - return regionLoadPB.getStorefileIndexSizeMB(); + public long getStorefileIndexSizeKB() { + return regionLoadPB.getStorefileIndexSizeKB(); The RegionLoad is exposed as IA.Public, so we can't remove the APIs without the Deprecate. The getStorefileIndexSizeMB() should be reserved and deprecated. + return ( int ) getStorefileIndexSizeKB() / 1024; It will be more precise to perform division before type cast.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Please fix failed tests.

        Thanks

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Please fix failed tests. Thanks
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 23s Maven dependency ordering for branch
        +1 mvninstall 4m 14s branch-2 passed
        +1 compile 2m 35s branch-2 passed
        +1 checkstyle 0m 52s branch-2 passed
        +1 mvneclipse 1m 14s branch-2 passed
        +1 findbugs 8m 29s branch-2 passed
        +1 javadoc 1m 45s branch-2 passed
        0 mvndep 0m 20s Maven dependency ordering for patch
        +1 mvninstall 2m 43s the patch passed
        +1 compile 2m 26s the patch passed
        +1 cc 2m 26s the patch passed
        +1 javac 2m 26s the patch passed
        +1 checkstyle 0m 46s the patch passed
        +1 mvneclipse 1m 13s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 hadoopcheck 36m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 41s the patch passed
        +1 findbugs 7m 28s the patch passed
        -1 javadoc 0m 16s hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 unit 0m 27s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 18s hbase-protocol in the patch passed.
        +1 unit 2m 31s hbase-client in the patch passed.
        +1 unit 93m 44s hbase-server in the patch passed.
        +1 unit 3m 42s hbase-rest in the patch passed.
        +1 asflicense 1m 9s The patch does not generate ASF License warnings.
        177m 0s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883969/HBASE-3935.branch-2.v3.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux d8525e5c16a6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision branch-2 / e07ff04
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/8347/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8347/artifact/patchprocess/diff-javadoc-javadoc-hbase-rest.txt
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8347/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8347/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 4m 14s branch-2 passed +1 compile 2m 35s branch-2 passed +1 checkstyle 0m 52s branch-2 passed +1 mvneclipse 1m 14s branch-2 passed +1 findbugs 8m 29s branch-2 passed +1 javadoc 1m 45s branch-2 passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 43s the patch passed +1 compile 2m 26s the patch passed +1 cc 2m 26s the patch passed +1 javac 2m 26s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvneclipse 1m 13s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 hadoopcheck 36m 0s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 41s the patch passed +1 findbugs 7m 28s the patch passed -1 javadoc 0m 16s hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 unit 0m 27s hbase-protocol-shaded in the patch passed. +1 unit 0m 18s hbase-protocol in the patch passed. +1 unit 2m 31s hbase-client in the patch passed. +1 unit 93m 44s hbase-server in the patch passed. +1 unit 3m 42s hbase-rest in the patch passed. +1 asflicense 1m 9s The patch does not generate ASF License warnings. 177m 0s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883969/HBASE-3935.branch-2.v3.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux d8525e5c16a6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / e07ff04 Default Java 1.8.0_144 findbugs v3.1.0-RC3 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/8347/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/8347/artifact/patchprocess/diff-javadoc-javadoc-hbase-rest.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8347/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8347/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        ServerLoad#getStorefileSizeInMB return ServerLoad#getStorefileIndexSizeKB / 1024

        We can achieve the same result by using right shift.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - ServerLoad#getStorefileSizeInMB return ServerLoad#getStorefileIndexSizeKB / 1024 We can achieve the same result by using right shift.
        Hide
        andy7904 Andy Yang added a comment -

        Ted Yu , thank for the advice.

        Show
        andy7904 Andy Yang added a comment - Ted Yu , thank for the advice.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 28s Maven dependency ordering for branch
        +1 mvninstall 3m 38s branch-2 passed
        +1 compile 2m 4s branch-2 passed
        +1 checkstyle 0m 49s branch-2 passed
        +1 mvneclipse 1m 11s branch-2 passed
        +1 findbugs 7m 54s branch-2 passed
        +1 javadoc 1m 37s branch-2 passed
        0 mvndep 0m 20s Maven dependency ordering for patch
        +1 mvninstall 2m 38s the patch passed
        +1 compile 2m 27s the patch passed
        +1 cc 2m 27s the patch passed
        +1 javac 2m 27s the patch passed
        +1 checkstyle 0m 44s the patch passed
        +1 mvneclipse 1m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 37m 32s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 39s the patch passed
        +1 findbugs 8m 35s the patch passed
        +1 javadoc 1m 28s the patch passed
        +1 unit 0m 30s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 21s hbase-protocol in the patch passed.
        +1 unit 2m 33s hbase-client in the patch passed.
        +1 unit 100m 47s hbase-server in the patch passed.
        +1 unit 3m 34s hbase-rest in the patch passed.
        +1 asflicense 1m 17s The patch does not generate ASF License warnings.
        185m 9s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883975/HBASE-3935.branch-2.v4.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux 11b79b93f844 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-2 / e07ff04
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8350/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8350/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 3m 38s branch-2 passed +1 compile 2m 4s branch-2 passed +1 checkstyle 0m 49s branch-2 passed +1 mvneclipse 1m 11s branch-2 passed +1 findbugs 7m 54s branch-2 passed +1 javadoc 1m 37s branch-2 passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 38s the patch passed +1 compile 2m 27s the patch passed +1 cc 2m 27s the patch passed +1 javac 2m 27s the patch passed +1 checkstyle 0m 44s the patch passed +1 mvneclipse 1m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 37m 32s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 39s the patch passed +1 findbugs 8m 35s the patch passed +1 javadoc 1m 28s the patch passed +1 unit 0m 30s hbase-protocol-shaded in the patch passed. +1 unit 0m 21s hbase-protocol in the patch passed. +1 unit 2m 33s hbase-client in the patch passed. +1 unit 100m 47s hbase-server in the patch passed. +1 unit 3m 34s hbase-rest in the patch passed. +1 asflicense 1m 17s The patch does not generate ASF License warnings. 185m 9s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883975/HBASE-3935.branch-2.v4.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux 11b79b93f844 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-2 / e07ff04 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8350/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8350/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chia7712 Chia-Ping Tsai added a comment -
            * The current total size of root-level store file indexes for the region,
            * in MB. The same as {@link #rootIndexSizeKB} but in MB.
            */
        -  optional uint32 storefile_index_size_MB = 7;
        +  optional uint64 storefile_index_size_KB = 7;
        

        Please fix the comment.

        The patch removes the storefile_index_size_MB, so the value of storefile_index_size_MB will be zero if user still use hbase-client 1.x. We need to mark this as incompatibility.

        Show
        chia7712 Chia-Ping Tsai added a comment - * The current total size of root-level store file indexes for the region, * in MB. The same as {@link #rootIndexSizeKB} but in MB. */ - optional uint32 storefile_index_size_MB = 7; + optional uint64 storefile_index_size_KB = 7; Please fix the comment. The patch removes the storefile_index_size_MB, so the value of storefile_index_size_MB will be zero if user still use hbase-client 1.x. We need to mark this as incompatibility.
        Hide
        andy7904 Andy Yang added a comment - - edited

        Chia-Ping Tsai, thank for remind.
        Modified the comment.

        Show
        andy7904 Andy Yang added a comment - - edited Chia-Ping Tsai , thank for remind. Modified the comment.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 32s Maven dependency ordering for branch
        +1 mvninstall 4m 17s branch-2 passed
        +1 compile 2m 29s branch-2 passed
        +1 checkstyle 0m 53s branch-2 passed
        +1 mvneclipse 1m 10s branch-2 passed
        +1 findbugs 8m 0s branch-2 passed
        +1 javadoc 1m 31s branch-2 passed
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 2m 56s the patch passed
        +1 compile 2m 33s the patch passed
        +1 cc 2m 33s the patch passed
        +1 javac 2m 33s the patch passed
        +1 checkstyle 0m 48s the patch passed
        +1 mvneclipse 1m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 37m 9s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 31s the patch passed
        +1 findbugs 8m 44s the patch passed
        +1 javadoc 1m 32s the patch passed
        +1 unit 0m 30s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 20s hbase-protocol in the patch passed.
        +1 unit 2m 38s hbase-client in the patch passed.
        +1 unit 93m 14s hbase-server in the patch passed.
        +1 unit 3m 8s hbase-rest in the patch passed.
        +1 asflicense 1m 7s The patch does not generate ASF License warnings.
        178m 16s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884035/HBASE-3935.branch-2.v5.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux 034e8102c38f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
        git revision branch-2 / 62c3439
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8361/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8361/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 4m 17s branch-2 passed +1 compile 2m 29s branch-2 passed +1 checkstyle 0m 53s branch-2 passed +1 mvneclipse 1m 10s branch-2 passed +1 findbugs 8m 0s branch-2 passed +1 javadoc 1m 31s branch-2 passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 56s the patch passed +1 compile 2m 33s the patch passed +1 cc 2m 33s the patch passed +1 javac 2m 33s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvneclipse 1m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 37m 9s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 31s the patch passed +1 findbugs 8m 44s the patch passed +1 javadoc 1m 32s the patch passed +1 unit 0m 30s hbase-protocol-shaded in the patch passed. +1 unit 0m 20s hbase-protocol in the patch passed. +1 unit 2m 38s hbase-client in the patch passed. +1 unit 93m 14s hbase-server in the patch passed. +1 unit 3m 8s hbase-rest in the patch passed. +1 asflicense 1m 7s The patch does not generate ASF License warnings. 178m 16s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884035/HBASE-3935.branch-2.v5.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux 034e8102c38f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision branch-2 / 62c3439 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8361/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8361/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        LGTM.
        Ted Yu Any more concerns?

        Show
        chia7712 Chia-Ping Tsai added a comment - LGTM. Ted Yu Any more concerns?
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        None.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - None.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 40s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 1m 40s Maven dependency ordering for branch
        +1 mvninstall 7m 19s branch-2 passed
        +1 compile 2m 48s branch-2 passed
        +1 checkstyle 2m 32s branch-2 passed
        +1 mvneclipse 1m 30s branch-2 passed
        +1 findbugs 7m 38s branch-2 passed
        +1 javadoc 1m 53s branch-2 passed
        0 mvndep 0m 22s Maven dependency ordering for patch
        +1 mvninstall 2m 55s the patch passed
        +1 compile 2m 28s the patch passed
        +1 cc 2m 28s the patch passed
        +1 javac 2m 28s the patch passed
        +1 checkstyle 0m 54s the patch passed
        +1 mvneclipse 1m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 32m 18s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 28s the patch passed
        +1 findbugs 6m 56s the patch passed
        +1 javadoc 1m 18s the patch passed
        +1 unit 0m 26s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 19s hbase-protocol in the patch passed.
        +1 unit 2m 22s hbase-client in the patch passed.
        +1 unit 113m 27s hbase-server in the patch passed.
        +1 unit 4m 21s hbase-rest in the patch passed.
        +1 asflicense 1m 10s The patch does not generate ASF License warnings.
        199m 21s



        Subsystem Report/Notes
        Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884082/HBASE-3935.branch-2.v5.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux 7dca0bab4a30 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision branch-2 / 5531be1
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8370/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8370/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 40s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 7m 19s branch-2 passed +1 compile 2m 48s branch-2 passed +1 checkstyle 2m 32s branch-2 passed +1 mvneclipse 1m 30s branch-2 passed +1 findbugs 7m 38s branch-2 passed +1 javadoc 1m 53s branch-2 passed 0 mvndep 0m 22s Maven dependency ordering for patch +1 mvninstall 2m 55s the patch passed +1 compile 2m 28s the patch passed +1 cc 2m 28s the patch passed +1 javac 2m 28s the patch passed +1 checkstyle 0m 54s the patch passed +1 mvneclipse 1m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 32m 18s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 28s the patch passed +1 findbugs 6m 56s the patch passed +1 javadoc 1m 18s the patch passed +1 unit 0m 26s hbase-protocol-shaded in the patch passed. +1 unit 0m 19s hbase-protocol in the patch passed. +1 unit 2m 22s hbase-client in the patch passed. +1 unit 113m 27s hbase-server in the patch passed. +1 unit 4m 21s hbase-rest in the patch passed. +1 asflicense 1m 10s The patch does not generate ASF License warnings. 199m 21s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884082/HBASE-3935.branch-2.v5.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux 7dca0bab4a30 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 5531be1 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8370/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8370/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 4m 5s branch-2 passed
        +1 compile 2m 20s branch-2 passed
        +1 checkstyle 0m 43s branch-2 passed
        +1 mvneclipse 1m 1s branch-2 passed
        +1 findbugs 6m 41s branch-2 passed
        +1 javadoc 1m 32s branch-2 passed
        0 mvndep 0m 21s Maven dependency ordering for patch
        +1 mvninstall 2m 34s the patch passed
        +1 compile 2m 6s the patch passed
        +1 cc 2m 6s the patch passed
        +1 javac 2m 6s the patch passed
        +1 checkstyle 0m 41s the patch passed
        +1 mvneclipse 0m 58s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 hadoopcheck 34m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
        +1 hbaseprotoc 1m 36s the patch passed
        +1 findbugs 7m 31s the patch passed
        +1 javadoc 1m 17s the patch passed
        +1 unit 0m 27s hbase-protocol-shaded in the patch passed.
        +1 unit 0m 19s hbase-protocol in the patch passed.
        +1 unit 2m 33s hbase-client in the patch passed.
        +1 unit 95m 35s hbase-server in the patch passed.
        +1 unit 2m 57s hbase-rest in the patch passed.
        +1 asflicense 1m 4s The patch does not generate ASF License warnings.
        172m 39s



        Subsystem Report/Notes
        Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364
        JIRA Issue HBASE-3935
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884092/HBASE-3935.branch-2.v6.patch
        Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc
        uname Linux fa619a796197 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
        git revision branch-2 / 5053ed9
        Default Java 1.8.0_144
        findbugs v3.1.0-RC3
        Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8371/testReport/
        modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: .
        Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8371/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 4m 5s branch-2 passed +1 compile 2m 20s branch-2 passed +1 checkstyle 0m 43s branch-2 passed +1 mvneclipse 1m 1s branch-2 passed +1 findbugs 6m 41s branch-2 passed +1 javadoc 1m 32s branch-2 passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 2m 34s the patch passed +1 compile 2m 6s the patch passed +1 cc 2m 6s the patch passed +1 javac 2m 6s the patch passed +1 checkstyle 0m 41s the patch passed +1 mvneclipse 0m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 34m 29s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 hbaseprotoc 1m 36s the patch passed +1 findbugs 7m 31s the patch passed +1 javadoc 1m 17s the patch passed +1 unit 0m 27s hbase-protocol-shaded in the patch passed. +1 unit 0m 19s hbase-protocol in the patch passed. +1 unit 2m 33s hbase-client in the patch passed. +1 unit 95m 35s hbase-server in the patch passed. +1 unit 2m 57s hbase-rest in the patch passed. +1 asflicense 1m 4s The patch does not generate ASF License warnings. 172m 39s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 JIRA Issue HBASE-3935 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884092/HBASE-3935.branch-2.v6.patch Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc uname Linux fa619a796197 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 5053ed9 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8371/testReport/ modules C: hbase-protocol-shaded hbase-protocol hbase-client hbase-server hbase-rest U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8371/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        Will commit it later.

        Show
        chia7712 Chia-Ping Tsai added a comment - Will commit it later.
        Hide
        chia7712 Chia-Ping Tsai added a comment -

        Thanks for the patch. Andy Yang
        Would you please fill the release note?

        Show
        chia7712 Chia-Ping Tsai added a comment - Thanks for the patch. Andy Yang Would you please fill the release note?
        Hide
        andy7904 Andy Yang added a comment -

        Ok, I will fill it later.

        Show
        andy7904 Andy Yang added a comment - Ok, I will fill it later.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3618 (See https://builds.apache.org/job/HBase-Trunk_matrix/3618/)
        HBASE-3935 HServerLoad.storefileIndexSizeMB should be changed to (chia7712: rev c91af3e7a4e8048a82601864c1949728bd3a2ce5)

        • (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java
        • (edit) hbase-protocol/src/main/protobuf/ClusterStatus.proto
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • (edit) hbase-rest/src/main/protobuf/StorageClusterStatusMessage.proto
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
        • (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
        • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        • (edit) hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto
        • (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
        • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3618 (See https://builds.apache.org/job/HBase-Trunk_matrix/3618/ ) HBASE-3935 HServerLoad.storefileIndexSizeMB should be changed to (chia7712: rev c91af3e7a4e8048a82601864c1949728bd3a2ce5) (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java (edit) hbase-protocol/src/main/protobuf/ClusterStatus.proto (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (edit) hbase-rest/src/main/protobuf/StorageClusterStatusMessage.proto (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java (edit) hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build HBase-2.0 #417 (See https://builds.apache.org/job/HBase-2.0/417/)
        HBASE-3935 HServerLoad.storefileIndexSizeMB should be changed to (chia7712: rev d26e22d75b581f834d34eb7b179ac4f4fe92fb88)

        • (edit) hbase-protocol/src/main/protobuf/ClusterStatus.proto
        • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
        • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        • (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java
        • (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
        • (edit) hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto
        • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
        • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java
        • (edit) hbase-rest/src/main/protobuf/StorageClusterStatusMessage.proto
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #417 (See https://builds.apache.org/job/HBase-2.0/417/ ) HBASE-3935 HServerLoad.storefileIndexSizeMB should be changed to (chia7712: rev d26e22d75b581f834d34eb7b179ac4f4fe92fb88) (edit) hbase-protocol/src/main/protobuf/ClusterStatus.proto (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java (edit) hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/StorageClusterStatusResource.java (edit) hbase-rest/src/main/protobuf/StorageClusterStatusMessage.proto

          People

          • Assignee:
            andy7904 Andy Yang
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development