Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-3862

Race conditions in aggregate calculation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.0
    • Fix Version/s: 0.92.0
    • Component/s: Coprocessors
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The AggregationClient requests aggregations from multiple region servers in parallel. The calculations in the reducer callbacks of the AggregationClient are not thread safe, and therefore could return an incorrect result due to simultaneous/interleaved execution.

        Activity

        Hide
        heitmann John Heitmann added a comment -

        This patch includes both a fix for the bug and unit tests. The fix is good, but the unit tests are a little dodgy. I had to jump through some hacky hoops to trigger the race, and being a race it doesn't happen all the time. The tests may be a maintenance problem in the future, and therefore you may not want to commit them.

        Show
        heitmann John Heitmann added a comment - This patch includes both a fix for the bug and unit tests. The fix is good, but the unit tests are a little dodgy. I had to jump through some hacky hoops to trigger the race, and being a race it doesn't happen all the time. The tests may be a maintenance problem in the future, and therefore you may not want to commit them.
        Hide
        stack stack added a comment -

        Committed to TRUNK. Thank you John for the fix. I committed changes to AggregateClient only. I left out the tests.

        Show
        stack stack added a comment - Committed to TRUNK. Thank you John for the fix. I committed changes to AggregateClient only. I left out the tests.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #1909 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1909/)

        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #1909 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1909/ )
        Hide
        lars_francke Lars Francke added a comment -

        This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

        Show
        lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          People

          • Assignee:
            Unassigned
            Reporter:
            heitmann John Heitmann
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development