HBase
  1. HBase
  2. HBASE-3850

Log more details when a scanner lease expires

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      noob

      Description

      The message logged by the RegionServer when a Scanner lease expires isn't as useful as it could be. Scanner 4765412385779771089 lease expired - most clients don't log their scanner ID, so it's really hard to figure out what was going on. I think it would be useful to at least log the name of the region on which the Scanner was open, and it would be great to have the ip:port of the client that had that lease too.

      1. HBASE-3850.trunk.v2.patch
        1 kB
        Darren Haas
      2. HBASE-3850.trunk.v1.patch
        1 kB
        Darren Haas
      3. 3850-v3.txt
        1 kB
        Ted Yu

        Issue Links

          Activity

          Hide
          Darren Haas added a comment -

          The attached file is a patch

          Show
          Darren Haas added a comment - The attached file is a patch
          Hide
          Ted Yu added a comment -

          Should we add tablename to the log as well ?
          I found only one implementation for RegionScanner:

            class RegionScannerImpl implements RegionScanner {
          src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          

          I didn't find much more information in RegionScannerImpl that would help us debug.

          Show
          Ted Yu added a comment - Should we add tablename to the log as well ? I found only one implementation for RegionScanner: class RegionScannerImpl implements RegionScanner { src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java I didn't find much more information in RegionScannerImpl that would help us debug.
          Hide
          stack added a comment -

          +1 on patch (fix spacing on the 'else' on commit)

          Won't regionname include name of table?

          Show
          stack added a comment - +1 on patch (fix spacing on the 'else' on commit) Won't regionname include name of table?
          Hide
          Mubarak Seyed added a comment -

          RegionScanner.getRegionInfo().getTableNameAsString() will give table name.

          Show
          Mubarak Seyed added a comment - RegionScanner.getRegionInfo().getTableNameAsString() will give table name.
          Hide
          Ted Yu added a comment -

          @Benoit:
          What do you think of the patch ?
          I haven't found a way of recording the ip:port of the client.

          Show
          Ted Yu added a comment - @Benoit: What do you think of the patch ? I haven't found a way of recording the ip:port of the client.
          Hide
          Darren Haas added a comment -

          Attached file contains updated patch

          Show
          Darren Haas added a comment - Attached file contains updated patch
          Hide
          Benoit Sigoure added a comment -

          Please respect the coding style and add the missing space after the else in the 2nd hunk of the patch.

          I wish we could get the ip:port of the client, but this patch is already a bit of an improvement, so let's commit it.

          Show
          Benoit Sigoure added a comment - Please respect the coding style and add the missing space after the else in the 2nd hunk of the patch. I wish we could get the ip:port of the client, but this patch is already a bit of an improvement, so let's commit it.
          Hide
          Ted Yu added a comment -

          Fixed spacing around else.

          Show
          Ted Yu added a comment - Fixed spacing around else.
          Hide
          Ted Yu added a comment -

          Integrated patch v3 to TRUNK.

          Thanks for the patch, Darren.

          Thanks for the review, Michael and Benoit.

          Show
          Ted Yu added a comment - Integrated patch v3 to TRUNK. Thanks for the patch, Darren. Thanks for the review, Michael and Benoit.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #101 (See https://builds.apache.org/job/HBase-TRUNK-security/101/)
          HBASE-3850 Log more details when a scanner lease expires (Darren Haas)

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #101 (See https://builds.apache.org/job/HBase-TRUNK-security/101/ ) HBASE-3850 Log more details when a scanner lease expires (Darren Haas) tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/)
          HBASE-3850 Log more details when a scanner lease expires (Darren Haas)

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/ ) HBASE-3850 Log more details when a scanner lease expires (Darren Haas) tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

            People

            • Assignee:
              Darren Haas
              Reporter:
              Benoit Sigoure
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development