Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 0.94.0
-
Component/s: regionserver
-
Labels:None
-
Hadoop Flags:Reviewed
-
Tags:noob
Description
The message logged by the RegionServer when a Scanner lease expires isn't as useful as it could be. Scanner 4765412385779771089 lease expired - most clients don't log their scanner ID, so it's really hard to figure out what was going on. I think it would be useful to at least log the name of the region on which the Scanner was open, and it would be great to have the ip:port of the client that had that lease too.
Issue Links
- is related to
-
HBASE-3859
Increment a counter when a Scanner lease expires
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Should we add tablename to the log as well ?
I found only one implementation for RegionScanner:
class RegionScannerImpl implements RegionScanner {
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
I didn't find much more information in RegionScannerImpl that would help us debug.
+1 on patch (fix spacing on the 'else' on commit)
Won't regionname include name of table?
RegionScanner.getRegionInfo().getTableNameAsString() will give table name.
@Benoit:
What do you think of the patch ?
I haven't found a way of recording the ip:port of the client.
Attached file contains updated patch
Please respect the coding style and add the missing space after the else in the 2nd hunk of the patch.
I wish we could get the ip:port of the client, but this patch is already a bit of an improvement, so let's commit it.
Fixed spacing around else.
Integrated patch v3 to TRUNK.
Thanks for the patch, Darren.
Thanks for the review, Michael and Benoit.
Integrated in HBase-TRUNK-security #101 (See https://builds.apache.org/job/HBase-TRUNK-security/101/)
HBASE-3850 Log more details when a scanner lease expires (Darren Haas)
tedyu :
Files :
- /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Integrated in HBase-TRUNK #2656 (See https://builds.apache.org/job/HBase-TRUNK/2656/)
HBASE-3850 Log more details when a scanner lease expires (Darren Haas)
tedyu :
Files :
- /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
The attached file is a patch