HBase
  1. HBase
  2. HBASE-3188

Review locking around AssignmentManager.regionPlans

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Not A Problem
    • Affects Version/s: 0.90.0
    • Fix Version/s: None
    • Component/s: master
    • Labels:
      None

      Description

      AssignmentManager.regionPlans is currently a ConcurrentSkipListMap so does not require synchronization. But sometimes we do multiple operations and we synchronize on it. But other times we don't synchronize on it at all.

      Let's review and make sure we're doing the right thing.

      Also see if we still need this AssignmentManager.updateTimers(). Don't we disable load balancer / expiration during startup or no?

        Issue Links

          Activity

          Jonathan Gray created issue -
          Nicolas Liochon made changes -
          Field Original Value New Value
          Link This issue relates to HBASE-7327 [ HBASE-7327 ]
          Hide
          Andrew Purtell added a comment - - edited

          Stale

          Show
          Andrew Purtell added a comment - - edited Stale
          Andrew Purtell made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Not a Problem [ 8 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1314d 20h 23m 1 Andrew Purtell 08/Jun/14 23:05

            People

            • Assignee:
              Unassigned
              Reporter:
              Jonathan Gray
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development