HBase
  1. HBase
  2. HBASE-2935

Refactor "Corrupt Data" Tests in TestHLogSplit

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.89.20100621
    • Fix Version/s: 0.90.0
    • Component/s: test
    • Labels:
      None

      Description

      While fixing HBASE-2643, I noticed that a couple of the HLogSplit tests from HBASE-2437 were now failing. 3 tests are trying to detect proper handling of garbage data: testCorruptedFileGetsArchivedIfSkipErrors, testTrailingGarbageCorruptionLogFileSkipErrorsFalseThrows, testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs. However, these tests are corrupting data at the HBase level. Data corruption should be tested at the HDFS level, because the filesystem is responsible for data validation. These tests need to inject corrupt data at the HDFS level & then verify that ChecksumExceptions are thrown.

        Issue Links

          Activity

          Nicolas Spiegelberg created issue -
          Nicolas Spiegelberg made changes -
          Field Original Value New Value
          Link This issue relates to HBASE-2437 [ HBASE-2437 ]
          Nicolas Spiegelberg made changes -
          Link This issue relates to HBASE-2643 [ HBASE-2643 ]
          Alex Newman made changes -
          Assignee Alex Newman [ posix4e ]
          Alex Newman made changes -
          Attachment 0001-HBASE-2935.-fix-testCorruptedFileGetsArchivedIfSkipE.patch [ 12458293 ]
          Alex Newman made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Alex Newman made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          Alex Newman made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note https://review.cloudera.org/r/1115/
          Alex Newman made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Alex Newman made changes -
          Alex Newman made changes -
          Attachment 0001-HBASE-2935.-fix-testCorruptedFileGetsArchivedIfSkipE.patch [ 12458293 ]
          Alex Newman made changes -
          Status In Progress [ 3 ] Patch Available [ 10002 ]
          stack made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.90.0 [ 12313607 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Alex Newman
              Reporter:
              Nicolas Spiegelberg
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development