[HBASE-2935] Refactor "Corrupt Data" Tests in TestHLogSplit

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.89.20100621
• Fix Version/s: 0.90.0
• Component/s: test
• Hadoop Flags: Reviewed
• Release Note: https://review.cloudera.org/r/1115/
• Assignee: Alex Newman
• Reporter: Nicolas Spiegelberg
• Created: 25/Aug/10 18:08
• Updated: 20/Nov/15 12:43
• Resolved: 04/Nov/10 23:40

Description

While fixing HBASE-2643, I noticed that a couple of the HLogSplit tests from HBASE-2437 were now failing. 3 tests are trying to detect proper handling of garbage data: testCorruptedFileGetsArchivedIfSkipErrors, testTrailingGarbageCorruptionLogFileSkipErrorsFalseThrows, testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs. However, these tests are corrupting data at the HBase level. Data corruption should be tested at the HDFS level, because the filesystem is responsible for data validation. These tests need to inject corrupt data at the HDFS level & then verify that ChecksumExceptions are thrown.

Issue Links

• relates to: HBASE-2643 Figure how to deal with eof splitting logs
• relates to: HBASE-2437 Refactor HLog splitLog