Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-2935

Refactor "Corrupt Data" Tests in TestHLogSplit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.89.20100621
    • Fix Version/s: 0.90.0
    • Component/s: test
    • Labels:
      None

      Description

      While fixing HBASE-2643, I noticed that a couple of the HLogSplit tests from HBASE-2437 were now failing. 3 tests are trying to detect proper handling of garbage data: testCorruptedFileGetsArchivedIfSkipErrors, testTrailingGarbageCorruptionLogFileSkipErrorsFalseThrows, testCorruptedLogFilesSkipErrorsFalseDoesNotTouchLogs. However, these tests are corrupting data at the HBase level. Data corruption should be tested at the HDFS level, because the filesystem is responsible for data validation. These tests need to inject corrupt data at the HDFS level & then verify that ChecksumExceptions are thrown.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                posix4e Alex Newman
                Reporter:
                nspiegelberg Nicolas Spiegelberg
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: