[HBASE-28809] Client always send flush requests twice when flush procedure is disabled

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.6.0, 4.0.0-alpha-1
• Component/s: Client

Environment

hbase 2.6.0

centos7

• Assignee: guluo
• Reporter: guluo
• Created: 02/Sep/24 12:32
• Updated: 03/Sep/24 12:34

Description

When hbase disable flush procedure at server side, whether flush procedure is diabled or not at clien side, client always sends flush requests twice.

In current hbase, There are four situations about flush request:
1. Both server and client enables flush Procedure, Client only sends a flush request by flush procedure.
2. Server disabled flush procedure and client enables flush procedurce, Client sends a flush request by flush procedure, after failure ,it will sends a flush request by old flush implementation
3. Server enables flush procedure and client disables flush procedure, Client only send a flush request by flush procedure
4. Both server and client disables flush Procedure, Client alwalys sends a flush request by flush procedure at first, after failure ,it will sends a flush request by old flush implementation 

 

The situation 1/2 is no problem.
For situation 3, I think client should only send a flush request by old flush implementation instead of flush procedure
For situation 4, I think client should only send a flush request by old flush implementation, instead of first using flush procedure, and then switching to old flush implementation after failing