[HBASE-28705] BackupLogCleaner cleans required WALs when using multiple backuproots

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.6.0, 3.0.0
• Fix Version/s: 2.7.0, 3.0.0-beta-2, 2.6.1
• Component/s: backup&restore
• Labels: pull-request-available
• Assignee: Dieter De Paepe
• Reporter: Dieter De Paepe
• Created: 02/Jul/24 14:01
• Updated: 27/Sep/24 07:02
• Resolved: 26/Sep/24 08:13

Description

The BackupLogCleaner is responsible for avoiding the deletion of WAL/logs that still need to be included in a future backup.

The logic to decide which files can be deleted does not work correctly when multiple backup roots are used. Each backup root has a different chain of backups (full, incremental1, incremental2, ...). So, if any chain requires a log, it should be preserved. This is not the case.

The result is that logs could be incorrectly deleted, resulting in data loss in backups.

PR incoming with test & fix.

Issue Links

• links to: GitHub Pull Request #6040
• links to: GitHub Pull Request #6304
• links to: GitHub Pull Request #6305
• links to: GitHub Pull Request #6306