Details

    • Reviewed

    Description

      Found this when digging HBASE-28522.

      First, this is not safe as MTP does not like DTP where we hold the exclusive lock all the time.
      Second, even if we hold the exclusive lock all the time, as showed in HBASE-28522, we may still hang there forever because SCP will not interrupt the TRSP.

      Attachments

        Issue Links

        Activity

          zhangduo Duo Zhang created issue -
          zhangduo Duo Zhang made changes -
          Field Original Value New Value
          Link This issue is related to HBASE-28522 [ HBASE-28522 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Labels pull-request-available
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          githubbot ASF GitHub Bot made changes -
          Remote Link This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ] This issue links to "GitHub Pull Request #5903 (Web Link)" [ 354525 ]
          zhangduo Duo Zhang added a comment -

          Pushed to branch-2.5+.

          Thanks Viraj Jasani for reviewing!

          zhangduo Duo Zhang added a comment - Pushed to branch-2.5+. Thanks Viraj Jasani for reviewing!
          zhangduo Duo Zhang made changes -
          Fix Version/s 2.7.0 [ 12353986 ]
          Fix Version/s 3.0.0-beta-2 [ 12354055 ]
          Fix Version/s 2.6.1 [ 12354132 ]
          Fix Version/s 2.5.9 [ 12354361 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          hudson Hudson added a comment -

          Results for branch branch-2.6
          build #127 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          +1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 jdk11 hadoop3 checks
          – For more information see jdk11 report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-2.6 build #127 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch branch-2
          build #1065 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          +1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 jdk11 hadoop3 checks
          – For more information see jdk11 report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-2 build #1065 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch branch-2.5
          build #537 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          +1 jdk8 hadoop2 checks
          – For more information see jdk8 (hadoop2) report

          -1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 jdk11 hadoop3 checks
          – For more information see jdk11 report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-2.5 build #537 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report +1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch branch-3
          build #216 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          -1 jdk11 hadoop3 checks
          – For more information see jdk11 report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch branch-3 build #216 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report -1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
          hudson Hudson added a comment -

          Results for branch master
          build #1084 on builds.a.o: -1 overall


          details (if available):

          -1 general checks
          – For more information see general report

          +1 jdk8 hadoop3 checks
          – For more information see jdk8 (hadoop3) report

          +1 jdk11 hadoop3 checks
          – For more information see jdk11 report

          +1 source release artifact
          – See build output for details.

          +1 client integration test

          hudson Hudson added a comment - Results for branch master build #1084 on builds.a.o : -1 overall details (if available): -1 general checks – For more information see general report +1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
          zhangduo Duo Zhang added a comment -

          Ah, when implementing HBASE-28522, I found that there is a very big problem that, in CloseExcessRegionReplicasProcedure, I forgot to call super.serializeStateData...

          This is a very critical problem as it may cause the loading of procedure store to fail and bring down the whole cluster...

          Andrew Kyle Purtell I think we need to make a 2.5.9.1 release to include an addendum for this fix...

          zhangduo Duo Zhang added a comment - Ah, when implementing HBASE-28522 , I found that there is a very big problem that, in CloseExcessRegionReplicasProcedure, I forgot to call super.serializeStateData... This is a very critical problem as it may cause the loading of procedure store to fail and bring down the whole cluster... Andrew Kyle Purtell I think we need to make a 2.5.9.1 release to include an addendum for this fix...
          zhangduo Duo Zhang made changes -
          Link This issue breaks HBASE-28740 [ HBASE-28740 ]

          People

            zhangduo Duo Zhang
            zhangduo Duo Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack