[HBASE-28575] Always printing error log when snapshot table

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.13
• Fix Version/s: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
• Component/s: snapshots
• Labels: pull-request-available

Environment

hbase2.4.13

Centos7

• Hadoop Flags: Reviewed
• Assignee: guluo
• Reporter: guluo
• Created: 07/May/24 15:18
• Updated: 09/May/24 06:37
• Resolved: 08/May/24 08:01

Description

Reproduction.

1. 
Disable snapshot procedure if your hbase support snapshot procedure feature
Set hbase.snapshot.procedure.enabled to false to disable snapshot procedure.

2.
Executing snapshot against a table, this step is no problem
snapshot 't01', 'sn0001'

3. 
HBase outputs error logs, as follow.
2024-05-07T23:16:37,175 ERROR [MASTER_SNAPSHOT_OPERATIONS-master/archlinux:16000-0] snapshot.TakeSnapshotHandler: Couldn't delete snapshot working directory:file:/opt/hbase/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/.hbase-snapshot/.tmp/sn001

 

The Reason.
HBase would clean tmp of the snapshot after snapshot. 
The tmp would be empty if snapshot was executed successfully
We would get false when calling `Filesystem.delete()` to delete the tmp which does not exist, so hbase outputs error logs.

Issue Links

• links to: GitHub Pull Request #5880