[HBASE-28424] Set correct Result to RegionActionResult for successful Put/Delete mutations

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Jing Yu
• Reporter: Viraj Jasani
• Created: 07/Mar/24 00:59
• Updated: 11/Mar/24 07:25
• Resolved: 10/Mar/24 08:47

Description

While returning response of multi(), RSRpcServices build the RegionActionResult with Result or Exception (ClientProtos.ResultOrException). It sets the Exception to this class in all cases where the operation fails with corresponding exception types e.g. NoSuchColumnFamilyException or FailedSanityCheckException etc.

In case of atomic mutations Increment and Append, we add the Result object to ClientProtos.ResultOrException, which is used by client to retrieve result from the batch API: Table#batch(List<? extends Row> actions, Object[] results).

Phoenix performs atomic mutation for Put using preBatchMutate() endpoint. Hence, returning Result object with ResultOrException is important for the purpose of returning the result back to the client as part of the atomic operation. Even if Phoenix returns the OperationStatus (with Result) to MiniBatchOperationInProgress, since HBase uses the empty Result for the Success case, the client would not be able to get the expected result.

case SUCCESS:
  builder.addResultOrException(
    getResultOrException(ClientProtos.Result.getDefaultInstance(), index));
  break; 

If OperationStatus returned by Region#batchMutate has valid Result object, it should be used by RSRpcServices while returning the response.

Issue Links

• is depended upon by: PHOENIX-6714 Return update status from Conditional Upserts
• links to: GitHub Pull Request #5760