[HBASE-28401] Introduce a close method for memstore for release active segment

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0, 3.0.0-beta-2, 2.5.9
• Component/s: in-memory-compaction, regionserver
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 24/Feb/24 09:10
• Updated: 19/Jul/24 15:15
• Resolved: 11/Mar/24 10:22

Description

Per the analysis in parent issue, we will always have an active segment in memstore even if it is empty, so if we do not call close on it, it will lead to a netty leak warning message.

Although there is no real memory leak for this case, we'd better still fix it as it may hide other memory leak problem.

Issue Links

• causes: HBASE-28742 CompactionTool fails with NPE when mslab is enabled
• causes: HBASE-28743 Snapshot based mapreduce jobs fails with NPE while trying to close mslab within mapper
• causes: PHOENIX-7367 Snapshot based mapreduce jobs fails after HBASE-28401
• links to: GitHub Pull Request #5705
• links to: GitHub Pull Request #5761