Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-28336

Fix casting bug in NettyRpcServer introduced in HBASE-28317

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.6.0, 3.0.0-beta-2
    • None
    • None

    Description

      I introduced a bug in HBASE-28317 that makes it useless. I tried to up-cast an array of java.security.cert.Certificate to an array of java.security.cert.X509Certificate, which doesn't work. I'll fix this in this ticket. This bug causes a lot of log spam and makes RpcCallContext.getClientCertificateChain() always return empty, but does not otherwise break the HBase server.

      I'm also immediately regretting my use of WARN logs when a certificate isn't present, because it turns out this happens on connections from localhost, so there's a lot of WARNs with stacktraces in the logs.

      Attachments

        Issue Links

          is caused by

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-28317 RpcCallContext should expose client's TLS certificate

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link GitHub Pull Request #5658

          Activity

            People

              charlesconnell Charles Connell
              charlesconnell Charles Connell
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: