[HBASE-28211] BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0, 3.0.0-alpha-4, 2.4.17, 2.5.6, 4.0.0-alpha-1
• Fix Version/s: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.7
• Assignee: Wellington Chevreuil
• Reporter: Wellington Chevreuil
• Created: 20/Nov/23 16:00
• Updated: 26/Dec/23 10:04
• Resolved: 29/Nov/23 12:51

Description

We add blocks to BucketCache.blocksByHFile on doDrain before we actually had successfully added the block to the cache. We may still fail to cache the block if it is too big to fit any of the configured bucket sizes, or if we fail to write it in the ioengine and reach the tolerated io errors threshold. In such cases, the related block would remain in the BucketCache.blocksByHFile indefinitely.

Issue Links

• links to: GitHub Pull Request #5530