[HBASE-28175] RpcLogDetails' Message can become corrupt before log is consumed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0, 3.0.0-beta-1, 2.5.7
• Assignee: Ray Mattingly
• Reporter: Ray Mattingly
• Created: 23/Oct/23 19:20
• Updated: 10/Nov/23 19:34
• Resolved: 09/Nov/23 18:15

Description

The RpcLogDetails class represents a slow (or large) log event which will later be consumed by the SlowLogQueueService.

Right now the RpcLogDetails' param field points to the slow call's Message, and this Message is backed by a CodedInputStream which may be overwritten before the given log is consumed. This overwriting of the Message may result in slow query payloads for which the metadata derived post-consumption is inaccurate.

To solve this bug I think we need to copy the Message in the RpcLogDetails constructor. I have this bug reproduced in a QA environment and will test out this idea and open a PR shortly if the test results are promising.

Issue Links

• links to: GitHub Pull Request #5481