[HBASE-27990] BucketCache causes ArithmeticException due to improper blockSize value checking

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6.0, 2.4.18, 3.0.0-beta-2, 2.5.9
• Component/s: BucketCache
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: ConfX
• Reporter: ConfX
• Created: 24/Jul/23 16:43
• Updated: 23/Apr/24 17:56
• Resolved: 29/Mar/24 07:45

Description

What happened

There is no value checking for parameter hbase.blockcache.minblocksize. This may cause improper calculations and crashes the system like division by 0.

Buggy code

In BucketCache.java, there is no value checking for blockSize and this variable is directly used to calculate the blockNumCapacity. When blockSize is mistakenly set to 0, the code would cause division by 0 and throw ArithmeticException to crash the system.

  public BucketCache(String ioEngineName, long capacity, int blockSize, int[] bucketSizes,
    int writerThreadNum, int writerQLen, String persistencePath, int ioErrorsTolerationDuration,
    Configuration conf) throws IOException {
    ...
    long blockNumCapacity = capacity / blockSize;
    ...

How to reproduce

(1) set hbase.blockcache.minblocksize=0
(2) run org.apache.hadoop.hbase.io.hfile.TestCacheConfig#testBucketCacheConfigL1L2Setup

you should observe the following failure:

java.lang.ArithmeticException: / by zero
    at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.<init>(BucketCache.java:282)
    at org.apache.hadoop.hbase.io.hfile.BlockCacheFactory.createBucketCache(BlockCacheFactory.java:238)
    at org.apache.hadoop.hbase.io.hfile.BlockCacheFactory.createBlockCache(BlockCacheFactory.java:110)
    at org.apache.hadoop.hbase.io.hfile.TestCacheConfig.testBucketCacheConfigL1L2Setup(TestCacheConfig.java:325)
        ...

For an easy reproduction, run the reproduce.sh in the attachment.

We are happy to provide a patch if this issue is confirmed.

Issue Links

• links to: GitHub Pull Request #5389