[HBASE-27986] Adding debug message and assertion for failed BlockCache creation

• Type: Sub-task
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: ConfX
• Created: 20/Jul/23 08:07
• Updated: 05/Apr/24 07:39

Description

What happened

After setting hfile.block.cache.size=1.1175870895385742E-8, running test org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache results in a NullPointerException.

Where's the bug

In the test org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache:

    BlockCache blockCache = BlockCacheFactory.createBlockCache(this.conf);
    logPerBlock(blockCache);
    addDataAndHits(blockCache, 3); 

Here the returned blockCache could be null, but is directly used as the parameter of logPerBlock without checking.

How to reproduce

1. Set hfile.block.cache.size=1.1175870895385742E-8
2. Run org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache
   and the following exception should be observed:

java.lang.NullPointerException	at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.logPerBlock(TestBlockCacheReporting.java:147)	at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testLruBlockCache(TestBlockCacheReporting.java:100) 

{{}}

Issue Links

• links to: GitHub Pull Request #5779