Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-2791

Stop dumping exceptions coming from ZK and do nothing about them

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: None
    • Labels:
      None

      Description

      I think this is part of the Master/ZooKeeper refactoring project but I'm putting it up here to be sure we cover it. Currently in ZKW (and other places around the code base) we do ZK operations and we don't really handle the exceptions, for example in ZKW.setClusterState:

          } catch (InterruptedException e) {
            LOG.warn("<" + instanceName + ">" + "Failed to set state node in ZooKeeper", e);
          } catch (KeeperException e) {
            if(e.code() == KeeperException.Code.NODEEXISTS) {
              LOG.debug("<" + instanceName + ">" + "State node exists.");
            } else {
              LOG.warn("<" + instanceName + ">" + "Failed to set state node in ZooKeeper", e);
            }
      

      This has been always like that since we started using ZK.

      What if the session was expired? What if it was only the connection that had a blip? Do we handle it correctly? We need to have this discussion.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jdcryans Jean-Daniel Cryans
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: