[HBASE-27851] TestListTablesByState is silently failing due to a surefire bug

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0, 3.0.0-alpha-4
• Component/s: test

Environment

Maven hbase-server tests

• Hadoop Flags: Reviewed
• Assignee: Jonathan Albrecht
• Reporter: Jonathan Albrecht
• Created: 09/May/23 15:45
• Updated: 12/May/23 19:22
• Resolved: 11/May/23 15:19

Description

Surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See:
 
https://issues.apache.org/jira/browse/SUREFIRE-2079
 
org.apache.hadoop.hbase.master.TestListTablesByState is currently failing in CI due to an error. However, it does not show up in the Test Results because of the surefire bug.
 
If you download the raw test_logs from the build artifacts, you will find the files:
/home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-jdk8-hadoop3/archiver/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestListTablesByState.txt
 
which contains:
-----------------------------------------------------------------------

Test set: org.apache.hadoop.hbase.master.TestListTablesByState

-----------------------------------------------------------------------

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.929 s - in org.apache.hadoop.hbase.master.TestListTablesByState

 
and /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-jdk8-hadoop3/archiver/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestListTablesByState-output.txt
 
which contains exceptions like:
...

2023-05-04T11:41:56,262 INFO  [RPCClient-NioEventLoopGroup-4-3 {}] client.RawAsyncHBaseAdmin$TableProcedureBiConsumer(2603): Operation: CREATE, Table Name: default:test failed with org.apache.hadoop.hbase.DoNotRetryIOException: Table test should have at least one column family.

        at

...

 
I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing.

Issue Links

• blocks: HBASE-27858 Update surefire version to 3.0.0 and use the SurefireForkNodeFactory
• links to: GitHub Pull Request #5227