[HBASE-2729] flushCache should write to a tmp directory and then move into the store directory

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.90.0
• Fix Version/s: 0.90.0
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Todd Lipcon
• Created: 15/Jun/10 05:56
• Updated: 20/Nov/15 15:40
• Resolved: 23/Jun/10 23:07

Description

Currently it appears that internalFlushCache writes directly to the target spot of the flushed data. The finally() block appends the metadata and closes the file as if nothing bad went wrong in case of an exception. This is really bad, since it means that an IOE in the middle of flushing cache could easily write a valid looking file with only half the data, which would then prevent us from recovering those edits during log replay.

Instead, it should flush to a tmp location and move it into the region dir only after it's successfully written.