[HBASE-27160] ClientZKSyncer.deleteDataForClientZkUntilSuccess should break from the loop when deletion is succeeded

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-4, 2.4.14
• Component/s: Client, Zookeeper
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 25/Jun/22 08:49
• Updated: 27/Jun/22 05:21
• Resolved: 26/Jun/22 07:33

Description

https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3745/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestSeparateClientZKCluster-output.txt

2022-06-25T04:53:00,316 DEBUG [ClientZKUpdater-/hbase/meta-region-server-1] zksyncer.ClientZKSyncer(200): Failed to delete node from client ZK, will retry later
org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/meta-region-server-1
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:118) ~[zookeeper-3.5.7.jar:3.5.7]
	at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[zookeeper-3.5.7.jar:3.5.7]
	at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1793) ~[zookeeper-3.5.7.jar:3.5.7]
	at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:210) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3]
	at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:851) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3]
	at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:843) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3]
	at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.deleteDataForClientZkUntilSuccess(ClientZKSyncer.java:198) ~[classes/:?]
	at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.access$400(ClientZKSyncer.java:45) ~[classes/:?]
	at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer$ClientZkUpdater.run(ClientZKSyncer.java:318) ~[classes/:?]

Not sure if this is the root cause of the flakiness but at least it messes up the output, let's fix it first.

Issue Links

• links to: GitHub Pull Request #4579