[HBASE-27046] The filenum in AbstractFSWAL should be monotone increasing

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.13
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 17/May/22 04:49
• Updated: 26/Jul/22 21:04
• Resolved: 09/Jun/22 11:41

Description

This is the current code

  /**
   * retrieve the next path to use for writing. Increments the internal filenum.
   */
  private Path getNewPath() throws IOException {
    this.filenum.set(EnvironmentEdgeManager.currentTime());
    Path newPath = getCurrentFileName();
    while (fs.exists(newPath)) {
      this.filenum.incrementAndGet();
      newPath = getCurrentFileName();
    }
    return newPath;
  }

In some tests, we inject our own EnvironmentEdge, it may return the same ts always or even go backwards, the logic here is not rnough to keep the filenum monotone increasing, as we may have already archive the old file.

Issue Links

• breaks: HBASE-27087 TestQuotaThrottle times out
• breaks: HBASE-27243 Fix TestQuotaThrottle after HBASE-27046
• is related to: HBASE-27243 Fix TestQuotaThrottle after HBASE-27046
• links to: GitHub Pull Request #4449