[HBASE-27035] failed to set file permission when node crash

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: lujie
• Created: 14/May/22 10:48
• Updated: 14/May/22 10:49

Description

 in SecureBulkLoadManager#secureBulkLoadHFiles, we have code like that:

for(Pair<byte[], String> el: familyPaths) {
              Path stageFamily = new Path(bulkToken, Bytes.toString(el.getFirst()));
              if(!fs.exists(stageFamily)) {
                fs.mkdirs(stageFamily);
                fs.setPermission(stageFamily, PERM_ALL_ACCESS);
             }
} 

if process crashbefore setpermission， and reboot, we can't setpermission again.

 

we should make this code like SnapshotScannerHDFSAclHelper#setCommonDirectoryPermission

 

 for (Path path : paths) {
      createDirIfNotExist(path);
      fs.setPermission(path, new FsPermission(
          conf.get(COMMON_DIRECTORY_PERMISSION, COMMON_DIRECTORY_PERMISSION_DEFAULT)))
}