[HBASE-27019] Minor compression performance improvements

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-3
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 10/May/22 02:07
• Updated: 18/May/22 06:06
• Resolved: 14/May/22 01:31

Description

TRACE level logging is expensive enough to warrant removal. They were useful during development but now are just overhead.

  1270039022    4.07%      127  jbyte_disjoint_arraycopy

e.g.

  [ 0] jbyte_disjoint_arraycopy
  [ 1] org.slf4j.impl.Reload4jLoggerAdapter.isTraceEnabled
  [ 2] org.slf4j.impl.Reload4jLoggerAdapter.trace
  [ 3] org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.setInput
  [ 4] org.apache.hadoop.io.compress.BlockCompressorStream.write
  [ 5] java.io.OutputStream.write
  [ 6] com.salesforce.hbase.util.TestUtils.outputStreamTest
  [ 7] com.salesforce.hbase.util.TestUtils.outputStreamTest
  [ 8] com.salesforce.hbase.BenchmarkAircompressorLz4.test
  [ 9] com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_avgt_jmhStub
  [10] com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_AverageTime

Also we unnecessarily create new LZ4 compressor and decompressor instances in the reset() methods.

Issue Links

• links to: GitHub Pull Request #4420