[HBASE-26989] TestStochasticLoadBalancer has some slow methods, and inconsistent set, reset, unset of configuration

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.0.0
• Fix Version/s: 2.5.0, 3.0.0-alpha-3
• Component/s: Balancer, test
• Hadoop Flags: Reviewed
• Assignee: David Manning
• Reporter: David Manning
• Created: 29/Apr/22 05:39
• Updated: 03/May/22 20:10
• Resolved: 02/May/22 18:47

Description

Some test ordering issues were exposed by adding new tests in HBASE-22349. I think this is a legitimate issue which is tracked in HBASE-26988.

But we can update the tests to be consistent in how they update configuration to reduce confusion, removing the unset calls.

We can also update other configuration values to significantly speed up the long-running methods. Methods that are simply checking for balancer plans do not need to runMaxSteps. All we need to do is run enough steps to guarantee we will plan to move one region. That can be far fewer than the tens of millions of steps we may be running given runMaxSteps.

Issue Links

• Discovered while testing: HBASE-22349 Stochastic Load Balancer skips balancing when node is replaced in cluster
• relates to: HBASE-26988 Balancer should reset to default setting for hbase.master.loadbalance.bytable if dynamically reloading configuration
• links to: GitHub Pull Request #4385