Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-26915 Miscellaneous improvements before landing spotless reformat
  3. HBASE-26922

Fix LineLength warnings as much as possible if it can not be fixed by spotless

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.5.0, 3.0.0-alpha-3, 2.4.12
    • None
    • None
    • Reviewed

    Description

      One possible problem is the trailing comment, Like this

            assertTrue(initialRegions
              .contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
                                                                                                  // is
                                                                                                  // the
                                                                                                  // replica
                                                                                                  // of
                                                                                                  // the
                                                                                                  // first
                                                                                                  // region
      

      Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.

      Let's move them from trailing to top of the statement.

      Attachments

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: