[HBASE-26869] RSRpcServices.scan should deep clone cells when RpcCallContext is null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-2, 2.4.11
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.12
• Component/s: regionserver
• Assignee: chenglei
• Reporter: chenglei
• Created: 20/Mar/22 11:41
• Updated: 13/Apr/23 09:07
• Resolved: 23/Mar/22 11:46

Description

When inspect HBASE-26812, I find that if RpcCallContext is null, RSRpcServices.scan does not set ServerCall.rpcCallback and directly closes RegionScannerImpl, but it does not deep clone the result cells , so these cells may be returned to the ByteBuffAllocator and may be overwritten before the caller reads them, similar as HBASE-26036, and at the same time, if RpcCallContext is null, when RSRpcServices.scan return partial results, it does not invoke RegionScannerImpl.shipped to release the used resources such as HFileScanner, pooled ByteBuffer etc.

No matter ShortCircuitingClusterConnection should be removed or not, I think this RSRpcServices.scan problem should fix for future maintainability.

Issue Links

• is related to: HBASE-26812 ShortCircuitingClusterConnection fails to close RegionScanners when making short-circuited calls
• links to: GitHub Pull Request #4249
• links to: GitHub Pull Request #4262
• links to: GitHub Pull Request #4263
• links to: GitHub Pull Request #4264
• links to: GitHub Pull Request #4265
• links to: GitHub Pull Request #4266