[HBASE-26767] Rest server should not use a large Header Cache.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.9
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.10
• Component/s: REST
• Hadoop Flags: Reviewed
• Assignee: Sergey Soldatov
• Reporter: Sergey Soldatov
• Created: 22/Feb/22 18:20
• Updated: 12/Mar/22 19:30
• Resolved: 24/Feb/22 00:48

Description

In the RESTServer we set the HeaderCache size to DEFAULT_HTTP_MAX_HEADER_SIZE (65536). That's not compatible with jetty-9.4.x because the cache size is limited by Character.MAX_VALUE - 1 (65534) there. According to the Jetty source code comments, it's possible to have a buffer overflow in the cache for higher values and that might lead to wrong/incomplete values returned by cache and following incorrect header handling.
There are a couple of ways to fix it:
1. change the value of DEFAULT_HTTP_MAX_HEADER_SIZE to 65534
2. make header cache size configurable and set its size separately from the header size.

I believe that the second would give us more flexibility.

Issue Links

• links to: GitHub Pull Request #4123