[HBASE-26741] Incorrect exception handling in shell

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5.0, 3.0.0-alpha-2, 2.4.10
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.10
• Component/s: shell
• Assignee: Peter Somogyi
• Reporter: Peter Somogyi
• Created: 07/Feb/22 17:02
• Updated: 31/Mar/22 12:21
• Resolved: 10/Feb/22 11:49

Description

The exception handling changed in the shell compared to 2.2.

➜  hbase-upstream git:(branch-2.4) ✗ cat commands.txt
scan 'foo'
exit
➜  hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
2022-02-07 16:21:33,654 WARN  [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
hbase:001:0> scan 'foo'
ROW                                  COLUMN+CELL
Took 0.3890 seconds                                                                                                                         Traceback (most recent call last):
RuntimeError (Unknown table foo!)
hbase:002:0> exit
➜  hbase-upstream git:(branch-2.4) ✗ echo $?
0 

The execution continues even after an exception is thrown. In 2.2.7 the execution stops when an exception is thrown and the shell exits with error code.

➜  hbase-2.2.7 bin/hbase shell -n commands.txt
2022-02-07 16:33:54,930 WARN  [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
ROW                                  COLUMN+CELL
Took 0.3082 seconds                                                                                                                         RuntimeError: Unknown table foo!
  translate_hbase_exceptions at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
                command_safe at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
            internal_command at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
                     command at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
                        scan at (eval):2
                      <main> at commands.txt:1
                        load at org/jruby/RubyKernel.java:973
                      <main> at /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
➜  hbase-2.2.7 echo $?
1 

Issue Links

• causes: HBASE-26880 Misspelling commands in hbase shell will crash the shell
• is related to: HBASE-26469 correct HBase shell exit behavior to match code passed to exit
• relates to: HBASE-26751 Tests for shell exit behavior
• links to: GitHub Pull Request #4101