[HBASE-26720] ExportSnapshot should validate the source snapshot before copying files

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.99.0, 1.0.0, 3.0.0-alpha-1, 2.0.0
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.12
• Component/s: snapshots
• Assignee: xi chaomin
• Reporter: David Manning
• Created: 28/Jan/22 01:14
• Updated: 01/Sep/22 10:57
• Resolved: 16/Mar/22 12:34

Description

Running ExportSnapshot with default parameters will copy the snapshot to a target location, and then use verifySnapshot to validate the integrity of the written snapshot. However, it is possible for the source snapshot to be invalid which leads to an invalid exported snapshot.

We can validate the source snapshot before export.

By default, we can validate the source snapshot unless the -no-target-verify parameter is set. We could also introduce a separate parameter for -no-source-verify if an operator wanted to validate the target but not validate the source for some reason, to provide some amount of backwards compatibility if that scenario is important.

Issue Links

• is related to: HBASE-10804 Add a validations step to ExportSnapshot
• links to: GitHub Pull Request #4216
• links to: https://github.com/apache/hbase/pull/4216