[HBASE-26494] Using RefCnt to fix the flawed MemStoreLABImpl

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-2, 2.4.9
• Fix Version/s: 2.5.0, 3.0.0-alpha-3
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: chenglei
• Reporter: chenglei
• Created: 27/Nov/21 04:25
• Updated: 04/Aug/23 02:41
• Resolved: 01/Jan/22 13:06

Description

As HBASE-26465 said, reference count implementation in MemStoreLABImpl is flawed because its checking and increasing or decreasing is not done in atomicity and it ignores state checking when there is illegal state in reference count(eg. increasing or decreasing when the resource is already freed) , just as following incScannerCount and decScannerCount methods illustrated, and this flawed implementation has shield the bugs HBASE-26465 and HBASE-26488.

  public void incScannerCount() {
    this.openScannerCount.incrementAndGet();
  }

  public void decScannerCount() {
    int count = this.openScannerCount.decrementAndGet();
    if (this.closed.get() && count == 0) {
      recycleChunks();
    }
  }

We could Introduce RefCnt into MemStoreLABImpl to replace its flawed reference count implementation, so checking and increasing or decreasing is done in atomicity and if there is illegal state in reference count, it would throw exception rather than continue using the corrupt data to cause some subtle bugs, and meanwhile, the code is more simpler.

Issue Links

• links to: GitHub Pull Request #3983