[HBASE-26476] Make DefaultMemStore extensible for HStore.memstore

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.4.8
• Fix Version/s: 2.5.0, 3.0.0-alpha-2, 2.4.9
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: chenglei
• Reporter: chenglei
• Created: 20/Nov/21 13:05
• Updated: 27/Nov/21 20:09
• Resolved: 27/Nov/21 04:11

Description

When HStore.memstore is DefaultMemStore , I find that it is impossible to extend DefaultMemStore to add some custom logic when I was work on HBASE-26465, because following code in HStore.getMemstore and HStore.getMemstore is a private method and is called in HStore ctor .We should make the DefaultMemStore extensible just as in branch-1.

    switch (inMemoryCompaction) {
      case NONE:
        ms = ReflectionUtils.newInstance(DefaultMemStore.class,
            new Object[] { conf, getComparator(),
                this.getHRegion().getRegionServicesForStores()});
        break;
      default:
        Class<? extends CompactingMemStore> clz = conf.getClass(MEMSTORE_CLASS_NAME,
            CompactingMemStore.class, CompactingMemStore.class);
        ms = ReflectionUtils.newInstance(clz, new Object[]{conf, getComparator(), this,
            this.getHRegion().getRegionServicesForStores(), inMemoryCompaction});
    }
    return ms;
  }

Issue Links

• links to: GitHub Pull Request #3869