[HBASE-26453] [hboss] removeInMemoryLocks can remove still in-use locks

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: hbase-filesystem-1.0.0-alpha1
• Fix Version/s: hbase-filesystem-1.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 12/Nov/21 15:59
• Updated: 18/Nov/21 01:16
• Resolved: 18/Nov/21 01:16

Description

While implementing HBASE-26437, I was fighting with unit tests which just wouldn't complete. After adding the code change to delete the locks held by the src in a mv src dst operation, releasing the dst lock would claim that the current thread doesn't hold the lock.

After investigating, the specific contract test in question is doing a rename of the form: mv /foo /foodest. This actually breaks the logic which tries to determine if a lock's path is contained beneath the path we're tryign to clean up. Specifically: cleaning up locks beneath /foo incorrectly removes locks for /foodest

Issue Links

• Discovered while testing: HBASE-26437 [hboss] Rename does not clean up znodes for src location
• links to: Pull request #29