[HBASE-26175] MetricsHBaseServer should record all kinds of Exceptions

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.11
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.12
• Component/s: metrics
• Assignee: Xiaolin Ha
• Reporter: Xiaolin Ha
• Created: 05/Aug/21 11:41
• Updated: 01/Sep/22 10:57
• Resolved: 24/Mar/22 11:11

Description

We can define a kind of Exception such as OtherExcpetions to record exceptions doesn't in the following kinds of exceptions. Only debug those exceptions by LOG.debug("Unknown exception type", throwable); is not helpful to find errors.

if (throwable != null) {
  if (throwable instanceof OutOfOrderScannerNextException) {
    source.outOfOrderException();
  } else if (throwable instanceof RegionTooBusyException) {
    source.tooBusyException();
  } else if (throwable instanceof UnknownScannerException) {
    source.unknownScannerException();
  } else if (throwable instanceof ScannerResetException) {
    source.scannerResetException();
  } else if (throwable instanceof RegionMovedException) {
    source.movedRegionException();
  } else if (throwable instanceof NotServingRegionException) {
    source.notServingRegionException();
  } else if (throwable instanceof FailedSanityCheckException) {
    source.failedSanityException();
  } else if (throwable instanceof MultiActionResultTooLarge) {
    source.multiActionTooLargeException();
  } else if (throwable instanceof CallQueueTooBigException) {
    source.callQueueTooBigException();
  } else if (throwable instanceof QuotaExceededException) {
    source.quotaExceededException();
  } else if (throwable instanceof RpcThrottlingException) {
    source.rpcThrottlingException();
  } else if (LOG.isDebugEnabled()) {
    LOG.debug("Unknown exception type", throwable);
  }
}

 

 

Issue Links

• links to: GitHub Pull Request #4248