[HBASE-25794] Fix checkstyle violations in hbase-table-reporter module

• Type: Task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: hbase-operator-tools-1.2.0
• Component/s: hbase-operator-tools
• Labels: beginner
• Assignee: Shanmukha Haripriya Kota
• Reporter: Peter Somogyi
• Created: 20/Apr/21 16:49
• Updated: 04/May/21 08:43
• Resolved: 04/May/21 08:43

Description

The hbase-table-reporter module in hbase-operator-tools has a bunch of checkstyle violations.

[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[22] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.Option' import.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[23] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLineParser' import.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[24] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLine' import.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[34,8] (imports) UnusedImports: Unused import - org.apache.hadoop.hbase.HRegionInfo.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[37] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.hadoop.hbase.client.*.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[41] (imports) ImportOrder: Wrong order for 'java.io.BufferedWriter' import.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[66,1] (design) HideUtilityClassConstructor: Utility classes should not have a public or default constructor.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[94] (sizes) LineLength: Line is longer than 100 characters (found 120).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[126] (sizes) LineLength: Line is longer than 100 characters (found 105).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[132] (sizes) LineLength: Line is longer than 100 characters (found 106).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[247] (indentation) Indentation: 'throws' has incorrect indentation level 2, expected level should be 4.
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[275] (sizes) LineLength: Line is longer than 100 characters (found 112).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[279] (sizes) LineLength: Line is longer than 100 characters (found 105).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[308] (sizes) LineLength: Line is longer than 100 characters (found 101).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[370] (sizes) LineLength: Line is longer than 100 characters (found 121).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[371] (sizes) LineLength: Line is longer than 100 characters (found 108).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[375] (sizes) LineLength: Line is longer than 100 characters (found 102).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[401] (sizes) LineLength: Line is longer than 100 characters (found 113).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[407] (sizes) LineLength: Line is longer than 100 characters (found 112).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[410] (sizes) LineLength: Line is longer than 100 characters (found 107).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[437] (sizes) LineLength: Line is longer than 100 characters (found 114).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[438] (sizes) LineLength: Line is longer than 100 characters (found 109).
[ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[445] (indentation) Indentation: 'throws' has incorrect indentation level 2, expected level should be 4.
[ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[27] (imports) ImportOrder: Wrong order for 'java.util.ArrayList' import.
[ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[30] (imports) ImportOrder: Wrong order for 'org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals' import.
[ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[59] (sizes) LineLength: Line is longer than 100 characters (found 110).
[ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[75] (sizes) LineLength: Line is longer than 100 characters (found 110).
[ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[80] (sizes) LineLength: Line is longer than 100 characters (found 111).

Issue Links

• links to: GitHub Pull Request #85