[HBASE-25792] Filter out o.a.hadoop.thirdparty building shaded jars

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.5.0, 2.4.3
• Fix Version/s: 3.0.0-alpha-1, 2.5.0, 2.4.3
• Component/s: shading
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 20/Apr/21 00:40
• Updated: 17/Feb/22 19:13
• Resolved: 27/Apr/21 15:43

Description

Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips the check in our shading that tries to exclude hadoop bits from the fat jars we build.

For the issue to trigger, need to build against tip of hadoop branch-3.3. You then get this complaint:

[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants ---
[ERROR] Found artifact with unexpected contents: '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar'
    Please check the following and either correct the build or update
    the allowed list with reasoning.

    org/apache/hadoop/thirdparty/
    org/apache/hadoop/thirdparty/com/
    org/apache/hadoop/thirdparty/com/google/
    org/apache/hadoop/thirdparty/com/google/common/
    org/apache/hadoop/thirdparty/com/google/common/annotations/
    org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class
    org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class
    org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class
    org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class
    org/apache/hadoop/thirdparty/com/google/common/base/
    org/apache/hadoop/thirdparty/com/google/common/base/Absent.class
    org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class
    org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class
    org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class
    org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class
    org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class

....

Issue Links

• breaks: HBASE-26546 hbase-shaded-client missing required thirdparty classes under hadoop 3.3.1
• breaks: HBASE-26760 LICENSE handling should not allow non-aggregated "apache-2.0"
• links to: GitHub Pull Request #3184