[HBASE-25750] Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX)

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.5.0, 2.4.3
• Fix Version/s: 3.0.0-alpha-1, 2.5.0, 2.4.3, 2.3.6
• Component/s: Coprocessors, phoenix, rpc
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 08/Apr/21 20:39
• Updated: 10/Apr/21 02:32
• Resolved: 09/Apr/21 00:52

Description

Phoenix has had an unrecognized dependency on RpcControllerFactory and HBaseRpcController for about four years. These interfaces are used to override setPriority for appropriate dispatch of requests for Phoenix system or index tables to separate pools. This is a reasonable use of these interfaces but the audience annotations were never updated to reflect this usage. Also seems reasonable to do so as there has been no issue here for four years. (Phoenix commit was made in 2017.) Make it official.

Issue Links

• fixes: PHOENIX-6438 Compilation failures after changes to Private annotated HBase class RpcControllerFactory
• links to: GitHub Pull Request #3136