[HBASE-25674] RegionInfo.parseFrom(DataInputStream) sometimes fails to read the protobuf magic marker

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.1
• Fix Version/s: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.3
• Component/s: Client
• Hadoop Flags: Reviewed
• Flags: Patch
• Assignee: Constantin-Catalin Luca
• Reporter: Constantin-Catalin Luca
• Created: 17/Mar/21 12:50
• Updated: 17/Jun/21 13:45
• Resolved: 18/Mar/21 18:58

Description

The RegionInfo class uses

 DataInputStream.read(byte[lengthOfPBMagic])

to read the protobuf magic marker from the beginning of the stream.
The code in RegionInfo assumes that the passed byte buffer will be filled, but the DataInputStream class only guarantees that it will read at most lengthOfPBMagic bytes.
This sometimes causes errors stating that region info file could not be parsed.
The fix is to simply issue multiple read calls until lengthOfPBMagic bytes have been read.

Issue Links

• is related to: HBASE-25859 Reference class incorrectly parses the protobuf magic marker
• links to: GitHub Pull Request #3062