[HBASE-25207] Revisit the implementation and usage of RegionStates.include

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
• Component/s: Region Assignment
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 20/Oct/20 15:22
• Updated: 17/Jun/22 18:04
• Resolved: 22/Oct/20 14:18

Description

After several round of refactoring and fixing, the method has been used in lots of places and the implementation looks really confusing.

As in the first if condition for testing RegionStateNode and RegionInfo state, we will always return false when split is true, which means we will always filter out split parent, as a split parent, is split = true and also offline = true.

I think the reason why there is no problem is that, only in EnableTableProcedure we call this method with offline = true, and EnableTableProcedure does not need to deal with split parent...

And now since we found a problem in HBASE-25206, where we need to get split parent when deleting a table, I think it is time to revisit this method and make logic less confusing.

Issue Links

• blocks: HBASE-25206 Data loss can happen if a cloned table loses original split region(delete table)
• is related to: HBASE-14614 Procedure v2: Core Assignment Manager
• is related to: HBASE-23187 Update parent region state to SPLIT in meta
• links to: GitHub Pull Request #2571