Details

    • Hadoop Flags:
      Reviewed

      Description

      If a storefilescanner fails to seek, it silently swallows the IOE and returns false as if it were the end of the scanner.

      This means that we can silently lose data if an IOE occurs for one of the store files during a compaction.

      1. hbase-2519-prelim.txt
        16 kB
        Todd Lipcon
      2. hbase-2519.txt
        27 kB
        Todd Lipcon
      3. hbase-2519.txt
        30 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          lars_francke Lars Francke added a comment -

          This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          Show
          lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).
          Hide
          stack stack added a comment -

          duh (fixed)

          Show
          stack stack added a comment - duh (fixed)
          Hide
          tlipcon Todd Lipcon added a comment -

          Stack: looks like you missed the test case when you committed this - TestFSErrorsExposed.java isn't in trunk.

          Show
          tlipcon Todd Lipcon added a comment - Stack: looks like you missed the test case when you committed this - TestFSErrorsExposed.java isn't in trunk.
          Hide
          stack stack added a comment -

          Committed. Thanks for patch Todd. Thanks for review over on review.hbase.org Ryan.

          Show
          stack stack added a comment - Committed. Thanks for patch Todd. Thanks for review over on review.hbase.org Ryan.
          Hide
          stack stack added a comment -

          I had two minor nits in review. I can fix them on commit. That ok?

          Show
          stack stack added a comment - I had two minor nits in review. I can fix them on commit. That ok?
          Hide
          apurtell Andrew Purtell added a comment -

          +1
          Like the new fault injection tests.

          Show
          apurtell Andrew Purtell added a comment - +1 Like the new fault injection tests.
          Hide
          tlipcon Todd Lipcon added a comment -
          Show
          tlipcon Todd Lipcon added a comment - Review here: http://review.hbase.org/r/75/
          Hide
          tlipcon Todd Lipcon added a comment -

          Rebased

          Show
          tlipcon Todd Lipcon added a comment - Rebased
          Hide
          ryanobjc ryan rawson added a comment -

          it needs to be rebased again unfortunately.

          Show
          ryanobjc ryan rawson added a comment - it needs to be rebased again unfortunately.
          Hide
          tlipcon Todd Lipcon added a comment -

          Anyone got time to look at this patch?

          Show
          tlipcon Todd Lipcon added a comment - Anyone got time to look at this patch?
          Hide
          tlipcon Todd Lipcon added a comment -

          Patch and test case attached.

          Show
          tlipcon Todd Lipcon added a comment - Patch and test case attached.
          Hide
          stack stack added a comment -

          Bulk move of 0.20.5 issues into 0.21.0 after vote that we merge branch into TRUNK up on list.

          Show
          stack stack added a comment - Bulk move of 0.20.5 issues into 0.21.0 after vote that we merge branch into TRUNK up on list.
          Hide
          tlipcon Todd Lipcon added a comment -

          All the way to the client - see attached patch for example (will write a targeted unit test before commit)

          Show
          tlipcon Todd Lipcon added a comment - All the way to the client - see attached patch for example (will write a targeted unit test before commit)
          Hide
          stack stack added a comment -

          In above when you say 'client', you mean the thread orchestrating the compaction or do you mean client using HTable API?

          Show
          stack stack added a comment - In above when you say 'client', you mean the thread orchestrating the compaction or do you mean client using HTable API?
          Hide
          tlipcon Todd Lipcon added a comment -

          In fact this needs to bubble all the way through to client - right now we also silently return no rows in a scanner in ScannerCallable on the client side if we get an IOE that isn't a DoNotRetryIOException or NSRE.

          Show
          tlipcon Todd Lipcon added a comment - In fact this needs to bubble all the way through to client - right now we also silently return no rows in a scanner in ScannerCallable on the client side if we get an IOE that isn't a DoNotRetryIOException or NSRE.

            People

            • Assignee:
              tlipcon Todd Lipcon
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development