[HBASE-25156] TestMasterFailover.testSimpleMasterFailover is flaky

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 05/Oct/20 21:28
• Updated: 25/Oct/20 09:44
• Resolved: 25/Oct/20 09:44

Description

[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 32.996 s <<< FAILURE! - in org.apache.hadoop.hbase.master.TestMasterFailover
[ERROR] org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover  Time elapsed: 12.317 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<2>
	at org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover(TestMasterFailover.java:133)

Looks like this test depends on metrics to be updated as a source of side-effect used to verify the test. Seems like it should retry the check a few times, or maybe we need a last-updated monotonic value that the test can check before and after it expects a change to be visible.

Issue Links

• is broken by: HBASE-24628 Region normalizer now respects a rate limit
• links to: GitHub Pull Request #2507
• links to: GitHub Pull Request #2516
• links to: GitHub Pull Request #2517
• links to: GitHub Pull Request #2518
• links to: GitHub Pull Request #2519
• links to: GitHub Pull Request #2529