[HBASE-25060] [HBOSS] TreeLockManager should not define itself as the default implementation for fs.hboss.sync.impl

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: hbase-filesystem-1.0.0-alpha1
• Fix Version/s: hbase-filesystem-1.0.0-alpha2
• Assignee: Wellington Chevreuil
• Reporter: Wellington Chevreuil
• Created: 17/Sep/20 19:20
• Updated: 18/Sep/20 08:33
• Resolved: 18/Sep/20 08:33

Description

Currently, abstract class TreeLockManager defines itself as the default implementation of fs.hboss.sync.impl. This is wrong, as in the event of fs.hboss.sync.impl omission from the config, it will end up trying to instantiate itself, failing as its abstract:

 2020-09-16 13:29:48,877 ERROR org.apache.hadoop.hbase.regionserver.HRegion: There was IO error when checking if the bulk load is ok in region wordcount,w,1600262698081.84cb78e467e3c3b40e78c7f07d643d5c..
java.io.IOException: Class referred to by fs.hboss.sync.impl, org.apache.hadoop.hbase.oss.sync.TreeLockManager, is not a valid implementation of org.apache.hadoop.hbase.oss.sync.TreeLockManager
        at org.apache.hadoop.hbase.oss.sync.TreeLockManager.get(TreeLockManager.java:70)
        at org.apache.hadoop.hbase.oss.HBaseObjectStoreSemantics.initialize(HBaseObjectStoreSemantics.java:120)
        at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3423)
        at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:158)
        at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3483)
        at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3451)
        at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:518)
        at org.apache.hadoop.fs.Path.getFileSystem(Path.java:361)
        at org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:818)
        at org.apache.hadoop.hbase.regionserver.HRegion.bulkLoadHFiles(HRegion.java:6221)
        at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:291)
        at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:266)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:360)

Issue Links

• links to: GitHub Pull Request #17