[HBASE-24995] MetaFixer fails to fix overlaps when multiple tables have overlaps

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.2.3
• Fix Version/s: 3.0.0-alpha-1, 2.4.0, 2.3.2
• Component/s: hbck2
• Hadoop Flags: Reviewed
• Assignee: Mohammad Arshad
• Reporter: Mohammad Arshad
• Created: 08/Sep/20 05:43
• Updated: 10/Sep/20 15:36
• Resolved: 08/Sep/20 19:04

Description

MetaFixer fails to fix overlaps when multiple tables have overlaps
Steps to reproduce from UT.

1. Create table t1 and t2 with split keys, ["bbb", "ccc", "ddd", "eee"]
2. Create extra region in both t1 and t2 with start key "bbb" and end key "ddd"
3. Run catalog janitor, It will report total 4 overlaps, 2 from each table.
4. Run MetaFixer, wait for merges to finish.
5. Run the catalog janitor again and verify report, there should not be any overlap
6. Overlap still exists. Reproduced!!!

Analysis.

• When I run the same scenario for just one table t1, overlaps are fixed successfully.
• Seems problem with MetaFixer#calculateMerges.
• I think merges should be calculated within a table. Across the table merge does not have significance.

Issue Links

• links to: GitHub Pull Request #2361