[HBASE-24750] All executor service should start using guava ThreadFactory

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.4.0
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 21/Jul/20 17:09
• Updated: 17/Sep/20 03:21
• Resolved: 12/Aug/20 10:28

Description

Currently, we have majority Executor services using guava's ThreadFactoryBuilder while creating fixed size thread pool. There are some executors using our internal hbase-common's Threads class which provides util methods for creating thread factory.

Although there is no perf impact, we should let all Executors start using our internal library for using ThreadFactory rather than having external guava dependency (which is nothing more than a builder class). We might have to add a couple more arguments to support full fledged ThreadFactory, but let's do it and stop using guava's builder class.

Update:

Based on the consensus, we should use only guava library and retire our internal code which maintains ThreadFactory creation.

Issue Links

• breaks: HBASE-25037 Lots of thread pool are changed to non daemon after HBASE-24750 which causes trouble when shutting down
• is related to: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread
• links to: GitHub Pull Request #2196
• links to: GitHub Pull Request #2214
• links to: GitHub Pull Request #2231